Skip to content

feat: ✨ Add User.collectibles#3107

Merged
plun1331 merged 15 commits intoPycord-Development:masterfrom
ToothyDev:feat/user-collectibles
Feb 17, 2026
Merged

feat: ✨ Add User.collectibles#3107
plun1331 merged 15 commits intoPycord-Development:masterfrom
ToothyDev:feat/user-collectibles

Conversation

@ToothyDev
Copy link
Contributor

@ToothyDev ToothyDev commented Feb 15, 2026

Summary

This PR aims to add User.collectibles to better reflect the current API surrounding collectibles / nameplates. Currently, this was opaquely aliased by User.nameplate, this is now done as an explicit alias.

For this, I added a new Collectibles class currently only holding the nameplate, which is accessible via User.collectibles.nameplate

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@pycord-app
Copy link

pycord-app bot commented Feb 15, 2026

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3107/head:pr-3107
git checkout pr-3107

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3107/head

@ToothyDev
Copy link
Contributor Author

Functionally this works as far as I tested, but I'm increasingly unhappy with the code handling in _update_inner_user because it now handles attributes that aren't available for each user-member-update pushed through the event, which that function originally somewhat expected apparently. I can probably change this if that's wanted

@ToothyDev ToothyDev force-pushed the feat/user-collectibles branch from 60e975a to 2f68072 Compare February 16, 2026 21:29
Paillat-dev
Paillat-dev previously approved these changes Feb 17, 2026
Copy link
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; tested (ish); wait for plun

@Paillat-dev Paillat-dev added this to the v2.8.0rc.1 milestone Feb 17, 2026
plun1331
plun1331 previously approved these changes Feb 17, 2026
auto-merge was automatically disabled February 17, 2026 22:31

Head branch was pushed to by a user without write access

@plun1331 plun1331 merged commit 59bf852 into Pycord-Development:master Feb 17, 2026
28 of 46 checks passed
@ToothyDev ToothyDev deleted the feat/user-collectibles branch February 17, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API reflection Discord API isn't correctly reflected feature Implements a feature hold: testing This pull request requires further testing priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants