Repository navigation
Read CSV and JSON files as UTF-8 regardless of platform charset - #175
Merged
Merged
Conversation
Source.fromFile / fromResource / fromURL fell back to the JVM default charset. On Windows with JDK 17 and earlier that is windows-1252, so non-ASCII text was garbled and a UTF-8 BOM arrived as "", which the BOM strip never matched. Pass Codec.UTF8 explicitly at every read, both in the compile-time macros and the runtime iterators. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source.fromFile / fromResource / fromURL fell back to the JVM default charset. On Windows with JDK 17 and earlier that is windows-1252, so non-ASCII text was garbled and a UTF-8 BOM arrived as "", which the BOM strip never matched. Pass Codec.UTF8 explicitly at every read, both in the compile-time macros and the runtime iterators.