Remove TACO from crisis plugin#51
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60263e5bbc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "strategy_plugin_route_no_action": "no crisis detected", | ||
| "strategy_plugin_route_true_crisis": "true crisis", | ||
| "strategy_plugin_route_taco_fake_crisis": "TACO fake crisis", | ||
| "strategy_plugin_route_unknown_route": "unknown status", | ||
| "strategy_plugin_action_no_action": "no action", | ||
| "strategy_plugin_action_watch_only": "notify only", |
There was a problem hiding this comment.
Map removed TACO enums to generic crisis labels
Removing the strategy_plugin_route_taco_fake_crisis / strategy_plugin_action_small_taco entries means translate_strategy_plugin_value now falls back to raw enum text when those values are present (application/runtime_strategy_adapters.py returns value when no i18n key exists), so user notifications can show taco_fake_crisis and small_taco instead of generic crisis wording. This is a regression for any older or external plugin signal payload that still emits those enums.
Useful? React with 👍 / 👎.
Remove legacy TACO route/action handling from the crisis plugin translation path. User-facing notifications now use only generic crisis status wording.