Skip to content

Remove TACO from crisis plugin#51

Merged
Pigbibi merged 2 commits into
mainfrom
fix/remove-legacy-taco-plugin-copy
May 16, 2026
Merged

Remove TACO from crisis plugin#51
Pigbibi merged 2 commits into
mainfrom
fix/remove-legacy-taco-plugin-copy

Conversation

@Pigbibi
Copy link
Copy Markdown
Collaborator

@Pigbibi Pigbibi commented May 11, 2026

Remove legacy TACO route/action handling from the crisis plugin translation path. User-facing notifications now use only generic crisis status wording.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60263e5bbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread notifications/telegram.py
Comment on lines 159 to 163
"strategy_plugin_route_no_action": "no crisis detected",
"strategy_plugin_route_true_crisis": "true crisis",
"strategy_plugin_route_taco_fake_crisis": "TACO fake crisis",
"strategy_plugin_route_unknown_route": "unknown status",
"strategy_plugin_action_no_action": "no action",
"strategy_plugin_action_watch_only": "notify only",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Map removed TACO enums to generic crisis labels

Removing the strategy_plugin_route_taco_fake_crisis / strategy_plugin_action_small_taco entries means translate_strategy_plugin_value now falls back to raw enum text when those values are present (application/runtime_strategy_adapters.py returns value when no i18n key exists), so user notifications can show taco_fake_crisis and small_taco instead of generic crisis wording. This is a regression for any older or external plugin signal payload that still emits those enums.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit 0a0239a into main May 16, 2026
1 check passed
@Pigbibi Pigbibi deleted the fix/remove-legacy-taco-plugin-copy branch May 16, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant