Limit IBKR 2FA auto-fill submissions#43
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 487da1ee39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try: | ||
| MAX_AUTOFILL_SUBMISSIONS = int(MAX_AUTOFILL_SUBMISSIONS_RAW) | ||
| except ValueError: | ||
| log.error("IBKR_2FA_MAX_SUBMISSIONS must be an integer") | ||
| sys.exit(1) |
There was a problem hiding this comment.
IBKR_2FA_MAX_SUBMISSIONS is parsed at import time, so the process exits on a non-integer value before validate_config() can honor IBKR_2FA_AUTOFILL=no. That changes the previous behavior where non-autofill mode skipped TOTP-related validation and still ran in monitor-only mode; with this commit, a malformed submission-limit env var can now prevent startup even when auto-fill is intentionally disabled.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification