Add IBKR SOXL plugin support#53
Conversation
a9a9588 to
06e1295
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9a9588085
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| log_context = build_request_log_context() | ||
| report = build_execution_report(log_context) | ||
| strategy_plugin_signals, strategy_plugin_error = load_strategy_plugin_signals() |
There was a problem hiding this comment.
Defer plugin signal loading until execution is allowed
handle_request now loads strategy plugin signals before both the run lock check and the market-open check, so overlapping or market-closed POSTs still execute plugin loading work. When IBKR_STRATEGY_PLUGIN_MOUNTS_JSON points to remote-backed plugin signals (for example GCS-based signal paths), skipped requests can still incur unnecessary I/O/latency and emit plugin-load diagnostics even though no strategy cycle will run. Move plugin loading inside the branch that has acquired the lock and passed the market-open gate.
Useful? React with 👍 / 👎.
Summary
Architecture
Tests