Add execution windows to runtime target#39
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aee01b4126
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| account_selector=_normalize_account_selector(account_selector), | ||
| account_scope=_normalize_optional_string(account_scope), | ||
| service_name=_normalize_optional_string(service_name), | ||
| execution_windows=dict(execution_windows) if execution_windows is not None else None, |
There was a problem hiding this comment.
build_runtime_target only does a top-level dict() copy for execution_windows, so nested structures remain shared with the caller. If the original nested mapping is mutated after construction, RuntimeTarget (declared frozen=True) silently changes, which can corrupt downstream logging/report context that expects the runtime target to be an immutable snapshot.
Useful? React with 👍 / 👎.
1 participant
Summary\n- add execution_windows to RuntimeTarget parsing and construction\n- document the precheck / probe / execution scheduler layout\n- add runtime target tests for execution window metadata\n\n## Validation\n- pytest tests/test_runtime_target.py -q\n- py_compile on modified files