Fold global ETF confidence gate into default profile#49
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4497ab0435
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| MIN_RECOMMENDED_EQUITY_USD: dict[str, float] = { | ||
| "global_etf_rotation": 3_000.0, | ||
| "global_etf_confidence_vol_gate": 3_000.0, | ||
| "tqqq_growth_income": 500.0, | ||
| "soxl_soxx_trend_income": 1_000.0, | ||
| "russell_1000_multi_factor_defensive": 30_000.0, |
There was a problem hiding this comment.
Preserve account-size warnings for legacy ETF alias
Add the legacy alias back to the minimum-equity lookup (or resolve aliases before lookup), because removing it makes build_account_size_diagnostics("global_etf_confidence_vol_gate", ...) return {} instead of the expected 3000 USD threshold. In any integration path that still passes the documented legacy profile name, small-account warnings are silently dropped even though this alias is supposed to behave the same as global_etf_rotation.
Useful? React with 👍 / 👎.
Summary
global_etf_rotationthe canonical SMA250 confidence/volatility-gated runtime profileglobal_etf_confidence_vol_gateas a legacy alias instead of a separate runtime-enabled profileTests
PYTHONPATH=src:../QuantPlatformKit/src .venv/bin/python -m pytest tests/test_catalog.py tests/test_entrypoints.py -q