Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes "compilation tests" (that tried compiling kernel boxes to Hugrs with HoleOps) - as HoleOp will not exist without the extension. Also the
-ccommand-line argument.Interpreter tests now check the test file (ignoring test directives) twice (rather than once plus once per test) - once as a "checking test"; a second time inside a
catchand then (if successful, i.e. nothing caught) uses the graph built for all the tests in that file.Allows test files containing
--!exec arguments --> [interpreter_result_string]and--!exec-hugr argumentsin addition to previous forms without arguments. (This is quite complex and might want more refactoring...)Some refactors (e.g.
rowToRonow taking aNamedPort; giving Raw.hs an export list and removingsplitM; breakingrunDesugarout fromdesugarEnv) could be done as a preliminary PR?TODO test coverage is still greatly reduced, until we've added in enough
--!exec-hugrs to replace the lost "compilation tests", really this should happen here.Also I am not sure but perhaps we should be using
Test/Examples.hsfor all test files??