Repository navigation
Read disposable performance from JSON - #38
Merged
Merged
Conversation
32 tasks done
ben-grande
force-pushed
the
preload-perf-json
branch
from
August 15, 2025 12:45
6aacfd1 to
5bd00f3
Compare
marmarek
reviewed
Aug 26, 2025
| for key, value in data.items(): | ||
| name = value["name"] | ||
| mean = value["mean"] | ||
| key = name + "(mean:" + mean + ")" |
Member
There was a problem hiding this comment.
TypeError: can only concatenate str (not "float") to str
marmarek
reviewed
Aug 26, 2025
| name = value["name"] | ||
| mean = value["mean"] | ||
| key = name + "(mean:" + mean + ")" | ||
| result[key] = float(value) |
Member
There was a problem hiding this comment.
and here value is a dict - float() doesn't work on it
Member
|
And finally, existing past jobs have the old format and the script loads those too for comparison - dropping old format support breaks that. |
Member
|
BTW, you can run the script yourself, it uses public API (except actually posting the comment, but with |
Contributor
Author
Yes, I never actually run this as I didn't knew, I should have asked for help/instructions. Is the command known to take long (more than 5 min)? I am using verbose and there are network connections for the first minute and then it hangs. Maybe there is something happening but not being logged. |
ben-grande
force-pushed
the
preload-perf-json
branch
from
August 27, 2025 12:14
5bd00f3 to
70a78a3
Compare
Member
|
It does take a while with the |
Contributor
Author
|
I didn't get a report from the public API yet (15 minutes hanging) but did commit on a best effort. |
Contributor
Author
|
Member
|
After making all those API calls, it should finish relatively quickly... |
marmarek
reviewed
Aug 27, 2025
| value = data[1] | ||
| data_dict = dict(v.split("=", maxsplit=1) for v in data[2:]) | ||
| key = name + "(avg:" + data_dict["average"] + ")" | ||
| result[key] = float(total) |
Member
There was a problem hiding this comment.
total is not set in this scope... value?
ben-grande
force-pushed
the
preload-perf-json
branch
3 times, most recently
from
August 27, 2025 14:50
4feb3e6 to
b37303b
Compare
Contributor
Author
|
marmarek
reviewed
Sep 4, 2025
| - btrfs-progs | ||
| - python3-nose2 | ||
| - python3-objgraph | ||
| - python3-deepmerge |
Member
There was a problem hiding this comment.
Wrap this in {% if grains['osrelease'] >= '4.3' %} (or just != '4.2') - the package is not available in F37 (R4.2 dom0).
ben-grande
force-pushed
the
preload-perf-json
branch
from
September 4, 2025 08:21
b37303b to
d849d0a
Compare
marmarek
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: QubesOS/qubes-issues#1512
Requires: QubesOS/qubes-core-admin#719