Templates: open URLs in disposables by notmuchtohide · Pull Request #665 · QubesOS/qubes-core-agent-linux

notmuchtohide · 2026-08-04T17:08:33Z

This is part of QubesOS/qubes-issues#6310, aiming to open Gnome Software URLs (project website, donation pages, etc.) in disposables.

This allows the user to check the project website safely before installing apps, while reducing the need for screenshots to recognize the apps in Gnome Software (QubesOS/qubes-issues#10983).

Previously, URLs were opened in offline browsers. However, if Gnome Software had access to the updates proxy (e.g. for Flatpak related actions) it would pass the proxy configurations to the browser and open the URL online.

Service ConditionGroup borrowed from qubes-notification-agent.

This is part of QubesOS/qubes-issues#6310, aiming to open Gnome Software URLs (project website, donation pages, etc.) in disposables. This allows the user to check the project website safely before installing apps, while reducing the need for screenshots to recognize the apps in Gnome Software (QubesOS/qubes-issues#10983). Previously, URLs were opened in offline browsers. However, if Gnome Software had access to the updates proxy (e.g. for Flatpak related actions) it would pass the proxy configurations to the browser and open the URL online. Service ConditionGroup borrowed from qubes-notification-agent.

ben-grande · 2026-08-05T11:28:21Z

Have you tried app-dispvm.*?
If that is unsuitable, please use the term dispvm rather than dvm.

marmarta · 2026-08-07T15:59:46Z

Have you tried app-dispvm.*?

I'm not sure if this makes sense here, opening all urls in a template in disposables makes I think a lot of sense and is more resilient to other package managers using packagekit or whatnot.

If that is unsuitable, please use the term dispvm rather than dvm.

agreed on that

andrewdavidwong · 2026-08-07T19:37:53Z

Suggestion: If you intend for this pull request to resolve the associated issue and would like for it to be linked to the issue automatically, you can put Closes QubesOS/qubes-issues#XXXX in the PR message (where XXXX is the issue number). Closes is one of several special keywords that GitHub will recognize. If and when the PR is merged, GitHub will automatically close the associated issue.

codecov · 2026-08-11T14:52:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.71%. Comparing base (a37fac9) to head (e1da340).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   71.31%   71.71%   +0.39%     
==========================================
  Files           3        3              
  Lines         502      502              
==========================================
+ Hits          358      360       +2     
+ Misses        144      142       -2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

multi-user is a system target and not a user target.

qubesos-bot · 2026-08-27T13:43:20Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026090821-devel&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update

system_tests_network_updates
- TC_00_Dom0Upgrade_whonix-gateway-18: test_005_update_flag_clear (error)
  subprocess.CalledProcessError: Command 'timeout=120; while ! tor-ci...

Failed tests

2 failures

system_tests_network_updates
- [unstable] TC_00_Dom0Upgrade_whonix-gateway-18: test_001_update_check (failure)
  ^... AssertionError: '' is not true
- TC_00_Dom0Upgrade_whonix-gateway-18: test_005_update_flag_clear (error)
  subprocess.CalledProcessError: Command 'timeout=120; while ! tor-ci...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/176874#dependencies
Nothing fixed

Unstable tests

Details

system_tests_network_updates
system_tests/Fail (2/5 times with errors)
- job 194439 Tests qubes.tests.integ.dom0_update failed (exit code 1), details r...
- job 194790 Tests qubes.tests.integ.dom0_update failed (exit code 1), details r...
system_tests/Fail (1/5 times with errors)
- job 194439 Tests qubes.tests.integ.vm_update failed (exit code 1), details rep...
system_tests/Failed (1/5 times with errors)
- job 194790 # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...
system_tests/Failed (1/5 times with errors)
- job 194439 # Test died: Some tests failed at qubesos/tests/system_tests.pm lin...
TC_00_Dom0Upgrade_whonix-gateway-18/test_000_update (1/5 times with errors)
- job 194790 Error: Failed to download metadata for repo 'test': Cannot download...
TC_00_Dom0Upgrade_whonix-gateway-18/test_001_update_check (1/5 times with errors)
- job 194439 ^... AssertionError: '' is not true
TC_00_Dom0Upgrade_whonix-gateway-18/test_006_update_flag_clear (1/5 times with errors)
- job 194790 Error: Failed to download metadata for repo 'test': Cannot download...
VmUpdates_fedora-44-xfce/test_120_updates_available_notification_qubes_vm_update (1/5 times with errors)
- job 194439 subprocess.CalledProcessError: Command '/usr/lib/qubes/upgrades-sta...

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

marmarek · 2026-09-04T00:34:52Z


            # Systemd preload-all
            preset_units /lib/systemd/system-preset/75-qubes-vm.preset initial
+            preset_units /usr/lib/systemd/user-preset/75-qubes-open-in-dispvm.preset initial --user


This should be --global option, --user does it only for the current user (which is root at package installation).

marmarek · 2026-09-04T00:34:56Z

            installSerialConf
        else
            preset_units /lib/systemd/system-preset/75-qubes-vm.preset upgrade
+            preset_units /usr/lib/systemd/user-preset/75-qubes-open-in-dispvm.preset upgrade --user


marmarek · 2026-09-04T00:35:08Z

 if [ $1 -eq 1 ]
 then
    preset_units %{_presetdir}/%qubes_preset_file initial
+    preset_units %{_userpresetdir}/75-qubes-open-in-dispvm.preset initial --user


marmarek · 2026-09-04T00:35:19Z

    changed=true
 else
    preset_units %{_presetdir}/%qubes_preset_file upgrade
+    preset_units %{_userpresetdir}/75-qubes-open-in-dispvm.preset upgrade --user


Rename dvm to dispvm

16d44b6

notmuchtohide added 4 commits August 15, 2026 11:22

Fix .desktop name

0619e77

Fix user-preset location

99988c1

Fix systemd install target

e1da340

multi-user is a system target and not a user target.

Add preset user services on initial and upgrade

6a31b93

marmarek added the openqa-pending label Aug 27, 2026

qubesos-qa Bot deployed to qa August 27, 2026 03:43 Active

marmarek requested changes Sep 4, 2026

View reviewed changes

Navigation Menu

Uh oh!

Uh oh!

Templates: open URLs in disposables - #665

Templates: open URLs in disposables#665
notmuchtohide wants to merge 6 commits into
QubesOS:mainfrom
notmuchtohide:template-open-url-dvm

notmuchtohide commented Aug 4, 2026 •

edited

Loading

Uh oh!

ben-grande commented Aug 5, 2026

Uh oh!

marmarta commented Aug 7, 2026

Uh oh!

andrewdavidwong commented Aug 7, 2026

Uh oh!

codecov Bot commented Aug 11, 2026 •

edited

Loading

Uh oh!

qubesos-bot commented Aug 27, 2026 •

edited

Loading

Uh oh!

marmarek Sep 4, 2026

Uh oh!

marmarek Sep 4, 2026

Uh oh!

marmarek Sep 4, 2026

Uh oh!

marmarek Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

notmuchtohide commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ben-grande commented Aug 5, 2026

Uh oh!

marmarta commented Aug 7, 2026

Uh oh!

andrewdavidwong commented Aug 7, 2026

Uh oh!

codecov Bot commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qubesos-bot commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

marmarek Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

marmarek Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

marmarek Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

marmarek Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

notmuchtohide commented Aug 4, 2026 •

edited

Loading

codecov Bot commented Aug 11, 2026 •

edited

Loading

qubesos-bot commented Aug 27, 2026 •

edited

Loading