Repository navigation
fix: fall back when service worker registration fulfills with undefined - #764
Merged
Merged
Conversation
馃 Changeset detectedLatest commit: 9b3fb1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gioboa
approved these changes
Oct 1, 2026
Merged
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snippet's
register().then()success callback readsswRegistration.activeunguarded. Some environments fulfillregister()withundefinedinstead of rejecting it. Playwright'sserviceWorkers: 'block'does this: I checked in Chromium, andnavigator.serviceWorker.register(...)resolves toundefined. The read then throwsTypeError: Cannot read properties of undefined (reading 'active')as an unhandled rejection. Partytown only recovers oncefallbackTimeoutfires (9999 ms by default).Reported downstream in withastro/astro#18171, which shows this in production on real Chrome/Android user agents as well as HeadlessChrome.
Change
fallback()right away, the same as a rejectedregister()(fix: fall back partytown scripts added after the fallback ran聽#751).Tests
tests/unit/snippet.spec.ts: new case whereregister()fulfills withundefined. It asserts the partytown script falls back to the main thread. Before the fix it fails with theTypeError.tests/platform/fallback: this test already usesserviceWorkers: 'block'. It passed only because of the 1 sfallbackTimeoutwhile the error went unnoticed. It now also asserts there are no page errors. That assertion fails onmainwith"Cannot read properties of undefined (reading 'active')"and passes with this change.pnpm test.unit: 52/52.playwright test tests/platform --browser=chromium: 44 passed.fmt.checkpasses.