Change amdmlss option to be activated via compile option#5008
Draft
Zhaeong wants to merge 2 commits into
Draft
Conversation
pfultz2
requested changes
Jun 24, 2026
|
|
||
| // Comma-separated list of ops to force onto AMDMLSS (e.g. "conv"). Empty lets | ||
| // MIGraphX decide. Mirrors the MIGRAPHX_MLSS_USE_SPECIFIC_OPS env var. | ||
| std::string mlss_use_specific_ops = ""; |
Collaborator
There was a problem hiding this comment.
This should not be added here. compile_options are options for all targets and this option is specific to the GPU backend. In #4990, I added backend options which you can use. It hasn't been integrated yet with the GPU.
Member
Author
There was a problem hiding this comment.
Ok sounds good, I can wait till that PR is merged and use backend options instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make AMDMLSS op selection controllable through MIGraphX's compile_options instead of only the MIGRAPHX_MLSS_USE_SPECIFIC_OPS environment variable. Under static-CRT linking, the EP's runtime env-var writes never reached MIGraphX's getenv.
Also used the std::string mlss_use_specific_ops field in the fuse_mlss pass (replacing the test-only enable_conv bool with a use_specific_ops string)