Sanitize benchmark mxr file name to use _ instead of invalid Windows characters#5024
Open
ahsan-ca wants to merge 5 commits into
Open
Sanitize benchmark mxr file name to use _ instead of invalid Windows characters#5024ahsan-ca wants to merge 5 commits into
_ instead of invalid Windows characters#5024ahsan-ca wants to merge 5 commits into
Conversation
ahsan-ca
force-pushed
the
change-benchmark-mxr-filename
branch
from
b5f11a8 to
442f654
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates GPU benchmark .mxr file naming to avoid :: in operator names (improving filename portability, especially on Windows), and adds a VS Code workspace settings file.
Changes:
- Sanitize
preop.name()when generating benchmark.mxrfilenames by replacing::with_. - Add
.vscode/settings.jsonwith workspace settings (remote extension kind + disable CMake configure-on-open).
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/targets/gpu/compile_ops.cpp | Sanitizes operator names before using them in benchmark .mxr filenames. |
| .vscode/settings.json | Adds VS Code workspace settings. |
ahsan-ca
force-pushed
the
change-benchmark-mxr-filename
branch
from
442f654 to
2726846
Compare
ahsan-ca
changed the title
_ instead of ::__ instead of ::
ahsan-ca
force-pushed
the
change-benchmark-mxr-filename
branch
from
2726846 to
ac65834
Compare
pfultz2
reviewed
Jun 30, 2026
| auto problem_hash = std::hash<std::string>{}(to_string(config->problem)); | ||
| auto mxr_file = mxr_dir / (preop.name() + "_" + std::to_string(i) + "_" + | ||
| // Sanitize the op name for use in a filename. Replace "::" with "__". | ||
| auto op_filename = replace_string(preop.name(), "::", "__"); |
Collaborator
There was a problem hiding this comment.
The pass_manager has a similar sanitize function, I wonder if we should reuse that somehow.
Contributor
Author
There was a problem hiding this comment.
I have made the changes for that. I had to pull the function from pass_manager out to be used for compile_ops. I have put it in filesystem.hpp, do you think it is better to keep it in filesystem.hpp or in stringutils.hpp?
ahsan-ca
force-pushed
the
change-benchmark-mxr-filename
branch
from
985f007 to
b13c749
Compare
Comment on lines
27
to
31
| #include <migraphx/config.hpp> | ||
| #include <algorithm> | ||
| #include <string> | ||
| #include <string_view> | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@pfultz2 wondering if we should move sanitize_filename() to stringutils.hpp for the above comment.
Contributor
Author
There was a problem hiding this comment.
I think fileutils.hpp is better suited for sanitize_filename() function.
Contributor
Author
There was a problem hiding this comment.
Made changes to move sanitize_filename() to fileutils.hpp. Re-requesting review after this change. @pfultz2
pfultz2
approved these changes
Jun 30, 2026
ahsan-ca
changed the title
__ instead of ::_ instead of invalid Windows characters
TedThemistokleous
approved these changes
Jun 30, 2026
TedThemistokleous
approved these changes
Jun 30, 2026
Comment on lines
+520
to
522
| auto op_filename = sanitize_filename(preop.name()); | ||
| auto mxr_file = mxr_dir / (op_filename + "_" + std::to_string(i) + "_" + | ||
| std::to_string(problem_hash) + ".mxr"); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5024 +/- ##
========================================
Coverage 92.73% 92.73%
========================================
Files 596 596
Lines 31813 31817 +4
========================================
+ Hits 29500 29504 +4
Misses 2313 2313
🚀 New features to boost your workflow:
|
Check flagged results 🔆 * No develop baseline was found for this PR's branch point; compared against the latest available develop run instead. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Windows has issues with filenames containing
::.This changes mxr file names to use
__instead of::.Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable