Don't throw an exception when using MIGRAPHX_GPU_DUMP_BENCHMARK_MXR#5025
Open
ahsan-ca wants to merge 1 commit into
Open
Don't throw an exception when using MIGRAPHX_GPU_DUMP_BENCHMARK_MXR#5025ahsan-ca wants to merge 1 commit into
ahsan-ca wants to merge 1 commit into
Conversation
pfultz2
approved these changes
Jun 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the GPU compilation flow when MIGRAPHX_GPU_DUMP_BENCHMARK_MXR is set so that, after dumping benchmark MXR files, it logs an informational message and terminates without throwing an exception.
Changes:
- Replaced a
MIGRAPHX_THROW(...)path with alog::info()message and early termination when benchmark MXR dumping is enabled. - Added
<cstdlib>to support the new termination call.
Comment on lines
+592
to
596
| log::info() << "Benchmark MXR files dumped to " << mxr_path | ||
| << ". Run the MXR files to create a problem cache, then recompile with the " | ||
| "cache."; | ||
| std::exit(0); | ||
| } |
TedThemistokleous
approved these changes
Jun 30, 2026
Regressions detected 🔴 * No develop baseline was found for this PR's branch point; compared against the latest available develop run instead. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We were throwing an exception when dumping benchmark-mxr files,
with MIGRAPHX_GPU_DUMP_BENCHMARK_MXR. This can be confusing
for the users. With this change, we print the message and exit without
throwing an exception.
Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable