Repository navigation
Run ctest in parallel in CI - #149
Merged
Merged
Conversation
The build and MinIO integration workflows already build with -j"$(nproc)" but ran the tests one at a time. Run them in parallel too. The package tests already share a RESOURCE_LOCK, and coverage profiles use %m, so concurrent tests merge their profiles instead of overwriting them.
derobins
requested review from
akolliasAMD,
gaoikawa,
jordan-turbofish,
kurtmcmillan,
riley-dixon,
sbates130272 and
zbyrne
as code owners
October 8, 2026 22:11
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused CI-only changes safely use existing test isolation and profile merging.
0 open findings
What changed in this PR
Runs CI tests in parallel to reduce workflow duration.
Changes:
- Adds
ctest -j"$(nproc)"to build and MinIO workflows. - Retains failure output and existing test synchronization.
| File | Description |
|---|---|
.github/workflows/hipobject-build.yml |
Parallelizes the main test suite. |
.github/workflows/hipobject-minio-integration-check.yml |
Parallelizes MinIO workflow unit tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build and MinIO integration workflows already build with -j"$(nproc)" but ran the tests one at a time. Run them in parallel too. The package tests already share a RESOURCE_LOCK, and coverage profiles use %m, so concurrent tests merge their profiles instead of overwriting them.