58 make a standard dashboard for mas results#59
Conversation
…en-environment-offset-is-non-zero' into 58-make-a-standard-dashboard-for-mas_results
…on for simulator seems broken
…viz. Improve CHANGELOG.md
…e more in one place. ci examples are now executed with tempfile
…-mas_results' into 58-make-a-standard-dashboard-for-mas_results # Conflicts: # agentlib/core/module.py
|
Update readme for new installation requirements. Currently, the following error message is displayed: |
|
Thanks for the very cool update. I think communications logging is a particularly good addition. One point: Is it possible to define the functions |
- deal with pydantic deprecation warning - update README.md - move some logging to debug level - move communicator result handling to a separate file
…anymore, instead it relies on agentloggers default. AgentLogger auto-increments existing file names, but only for default
…shboard-for-mas_results # Conflicts: # CHANGELOG.md # agentlib/__init__.py # agentlib/modules/communicator/mqtt.py # agentlib/modules/utils/agent_logger.py # examples/multi-agent-systems/room_mas/room_mas.py
FWuellhorst
left a comment
FWuellhorst
left a comment
There was a problem hiding this comment.
@EserSteffen looks really nice. The "live" option only sort of worked for me, but the example is also really fast.
Really cool feature, only minor comments.
| # communicator without json parsing | ||
| payload = comm_no_parse.short_dict( | ||
| variable, parse_json=comm_no_parse.config.parse_json | ||
| ) | ||
| payload = comm_no_parse.short_dict(variable) | ||
| payload["name"] = payload["alias"] | ||
| variable2 = AgentVariable(**payload) |
There was a problem hiding this comment.
tests for the new functions should be added (comm log)
| self._run_example_with_return( | ||
| file="simulation//csv_data_source.py", | ||
| func_name="run_example", | ||
| with_plots=False, | ||
| log_level=logging.FATAL, | ||
| extrapolation="backwards" | ||
| extrapolation="backwards", |
There was a problem hiding this comment.
run room_mas with dashboad True to check if it works in CI?!
| class MultiProcessingSubscriptionClientConfig(SubscriptionCommunicatorConfig): | ||
| ipv4: IPv4Address = Field( |
|
@EserSteffen I got the task to go over this and hand off to someone else. |
6 participants
No description provided.