Skip to content

Fix crash when localPort or connectedPort is nil (new) #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsheffers wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix crash when localPort or connectedPort is nil (new) #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions ios/TcpSockets.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,20 +219,23 @@ - (void)onWrittenData:(TcpSocketClient *)client msgId:(NSNumber *)msgId {

- (void)onConnect:(TcpSocketClient *)client {
GCDAsyncSocket *socket = [client getSocket];
[self sendEventWithName:@"connect"
body:@{
@"id" : client.id,
@"connection" : @{
@"localAddress" : [socket localHost],
@"localPort" :
[NSNumber numberWithInt:[socket localPort]],
@"remoteAddress" : [socket connectedHost],
@"remotePort" : [NSNumber
numberWithInt:[socket connectedPort]],
@"remoteFamily" : [socket isIPv4] ? @"IPv4"
: @"IPv6"
}
}];
if([socket localPort] != nil && [socket connectedPort] != nil) {
[self sendEventWithName:@"connect"
body:@{
@"id" : client.id,
@"connection" : @{
@"localAddress" : [socket localHost],
@"localPort" :
[NSNumber numberWithInt:[socket localPort]],
@"remoteAddress" : [socket connectedHost],
@"remotePort" : [NSNumber
numberWithInt:[socket connectedPort]],
@"remoteFamily" : [socket isIPv4] ? @"IPv4"
: @"IPv6"
}
}];
}

}

- (void)onListen:(TcpSocketClient *)server {
Expand Down