Build for Windows and Linux ARM64 in CI - #60
Conversation
|
Warning Review limit reached
Next review available in: 45 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe CI workflows now build Linux and Windows targets for x64 and arm64. Architecture-specific toolchains, caches, artifacts, and parallelism are configured. ARM64 ChangesArchitecture matrix CI
ARM64 vector support
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/linux_build.yml:
- Around line 40-43: Validate each downloaded CMake archive before extraction in
the workflow’s CMake setup step: download the official cmake-4.4.2-SHA-256.txt
file, verify the architecture-specific archive against its listed SHA-256
checksum, and only run tar -xzf after verification succeeds for both
archive-download paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: dd8ebdf9-f254-47d9-a0e4-000166ca9d7f
📒 Files selected for processing (3)
.github/workflows/linux_build.yml.github/workflows/windows_build.ymlEngine/cpp/Runtime/Core/Math/Vector4.cppm
3baccc6 to
ee678b3
Compare
|
I believe it was intentional for CI to run on every branch so that every PR has it run, but I am not exactly sure how that parameter works. Is it what branch the PR is trying to merge into? If so then your change is probably good |
Yea, it's the branch it's trying to merge into. The changes lgtm & can be merged |
The PR trigger makes the workflow run regardless of target branch. Using a wildcard for the branch trigger makes the workflow run regardless of the existence of a PR. To just remove the duplicated runs but still run on every branch, the wildcard could be kept and the PR trigger removed entirely, but usually main branch + PRs are sufficient. |
I agree, the changes to the CI here all make sense and look good to me. @JoltedJon I have gone ahead and approved the workflows to run. I think my only concern is I am not sure if arm64 will build and work properly or not at this time. I am not sure how many stub implementations for arm64 there are within the code base and build system at this time. I dont believe this architecture has really undergone any testing yet on account of all of the core devs working off of x86_64. |
Arctis-Fireblight
left a comment
There was a problem hiding this comment.
It looks like everything built and tested properly for arm64, so I will go ahead and throw my approval on this.
egor-tensin/setup-clangfrom v1 to v2actions/upload-artifactfrom v4 to v7Summary by CodeRabbit
New Features
Build & Platform Support