Skip to content

feat: make "create new node" description panel resizable (#1135) - #1331

Merged
JoltedJon merged 3 commits into
Redot-Engine:masterfrom
joey-wheeler99:master
Aug 2, 2026
Merged

feat: make "create new node" description panel resizable (#1135)#1331
JoltedJon merged 3 commits into
Redot-Engine:masterfrom
joey-wheeler99:master

Conversation

@joey-wheeler99

@joey-wheeler99 joey-wheeler99 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Implements feature request from #1135

Summary by CodeRabbit

  • UI Improvements
    • Improved the Create dialog layout by reorganizing the Favorites and Recent sections into a clearer left-side arrangement.
    • Updated the right side to better separate search/matches from the description area for a more readable, focused workflow.
    • Refined spacing and sizing of the description help content to improve alignment and overall visual consistency.

@joey-wheeler99
joey-wheeler99 requested review from a team July 27, 2026 02:58
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 733234b5-d415-4974-a812-7268b3f5ff11

📥 Commits

Reviewing files that changed from the base of the PR and between 11a6eea and 99319fa.

📒 Files selected for processing (1)
  • editor/gui/create_dialog.cpp
🚧 Files skipped from review as they are similar to previous changes (1)
  • editor/gui/create_dialog.cpp

Walkthrough

CreateDialog now uses dedicated split containers for Favorites and Recent, and for the search/matches and description sections.

Changes

Create dialog layout

Layer / File(s) Summary
Reorganize dialog containers
editor/gui/create_dialog.cpp
Adds split-container includes, attaches Favorites and Recent to left_vsc, and separates search/matches and description into sibling containers under right_vsc; help_bit moves into desc_vb.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: making the Create New Node description panel resizable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@editor/gui/create_dialog.cpp`:
- Around line 939-943: Update the description UI setup around help_bit and
desc_vb so the content expands with the splitter: set help_bit’s vertical size
flags to Control::SIZE_EXPAND_FILL and pass true as the expandable argument to
desc_vb->add_margin_child. Preserve the existing label and sizing configuration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4bad883e-1ac4-4798-a316-fe9dfd5ae109

📥 Commits

Reviewing files that changed from the base of the PR and between 9fe4edb and ead75a1.

📒 Files selected for processing (1)
  • editor/gui/create_dialog.cpp

Comment thread editor/gui/create_dialog.cpp Outdated
@joey-wheeler99
joey-wheeler99 marked this pull request as draft July 27, 2026 07:28
@joey-wheeler99

Copy link
Copy Markdown
Contributor Author

I'm inspecting whyEditorHelpBitnot following the size of its parent.

@joey-wheeler99
joey-wheeler99 force-pushed the master branch 2 times, most recently from 7b345cc to e496e0a Compare July 28, 2026 05:21
@joey-wheeler99
joey-wheeler99 marked this pull request as ready for review July 28, 2026 06:43
@joey-wheeler99

Copy link
Copy Markdown
Contributor Author

The reasons why description panel was not resizable were:

  • It's not a child of any split container.
  • The vertical flag of Its content's RichTextLabel which lives inside EditorHelpBitwas not set to expand fill.

Solution:

  • I added the description panel to a VSplitContainer.
  • I set the vertical flag of content's RichTextLabel to expand fill. There are two choices to set this flag. Either do it in the user of EditorHelpBit or in the EditorHelpBit itself. I tried to avoid changing the default behaviour of content's RichTextLabel inEditorHelpBit class. I'm afraid of other classes use it and want it in the original flag.

@JoltedJon

Copy link
Copy Markdown
Contributor

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

JoltedJon
JoltedJon previously approved these changes Aug 1, 2026

@JoltedJon JoltedJon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! This bugged me quite a bit and I remember seeing this issue a couple months ago. Glad to see someone implemented it.
Tested and works great

@VictorSohier VictorSohier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoltedJon

Copy link
Copy Markdown
Contributor

@joey-wheeler99 Could you please run pre-commit run --all-files then commit the fixes when you get the chance to fix the style issues you have?
You can see the failing job here https://github.com/Redot-Engine/redot-engine/actions/runs/30683986006/job/91377146897?pr=1331

If you have any issues please let me know on discord

Shakai-Dev
Shakai-Dev previously approved these changes Aug 1, 2026

@Shakai-Dev Shakai-Dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joey-wheeler99
joey-wheeler99 dismissed stale reviews from Shakai-Dev and JoltedJon via 99319fa August 1, 2026 23:39

@joey-wheeler99 joey-wheeler99 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix formatting

@JoltedJon
JoltedJon enabled auto-merge (squash) August 2, 2026 02:05

@Shakai-Dev Shakai-Dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoltedJon
JoltedJon merged commit 79f71bd into Redot-Engine:master Aug 2, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI Issue: "Description" in "Create New Node" is fixed size

4 participants