feat: make "create new node" description panel resizable (#1135) - #1331
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough
ChangesCreate dialog layout
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@editor/gui/create_dialog.cpp`:
- Around line 939-943: Update the description UI setup around help_bit and
desc_vb so the content expands with the splitter: set help_bit’s vertical size
flags to Control::SIZE_EXPAND_FILL and pass true as the expandable argument to
desc_vb->add_margin_child. Preserve the existing label and sizing configuration.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4bad883e-1ac4-4798-a316-fe9dfd5ae109
📒 Files selected for processing (1)
editor/gui/create_dialog.cpp
|
I'm inspecting why |
7b345cc to
e496e0a
Compare
|
The reasons why description panel was not resizable were:
Solution:
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
JoltedJon
left a comment
There was a problem hiding this comment.
Great change! This bugged me quite a bit and I remember seeing this issue a couple months ago. Glad to see someone implemented it.
Tested and works great
|
@joey-wheeler99 Could you please run If you have any issues please let me know on discord |
99319fa
joey-wheeler99
left a comment
There was a problem hiding this comment.
Fix formatting
Implements feature request from #1135
Summary by CodeRabbit