Skip to content

Provide icon for monotonic cubic interpolation - #1334

Merged
JoltedJon merged 1 commit into
Redot-Engine:masterfrom
VictorSohier:monotonic-cubic-bug-fix
Aug 1, 2026
Merged

Provide icon for monotonic cubic interpolation#1334
JoltedJon merged 1 commit into
Redot-Engine:masterfrom
VictorSohier:monotonic-cubic-bug-fix

Conversation

@VictorSohier

@VictorSohier VictorSohier commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #1333

Summary by CodeRabbit

  • UI Improvements
    • Added visual indicators for the additional monotonic and monotonic-angle interpolation modes in the animation track editor.
    • Updated interpolation icon mapping to display the correct icon for the expanded set of interpolation options.

@VictorSohier
VictorSohier requested review from a team July 29, 2026 14:26
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f45a791e-8040-49ab-9023-d323d7cdcd2f

📥 Commits

Reviewing files that changed from the base of the PR and between a9bf86c and 1967b41.

📒 Files selected for processing (1)
  • editor/animation/animation_track_editor.cpp
🚧 Files skipped from review as they are similar to previous changes (1)
  • editor/animation/animation_track_editor.cpp

Walkthrough

The animation track editor expands its interpolation icon mapping from five entries to seven, adding icons for monotonic cubic and monotonic angle interpolation modes.

Changes

Animation interpolation icons

Layer / File(s) Summary
Expand interpolation icon mapping
editor/animation/animation_track_editor.cpp
The interp_icon array now includes InterpMonotonic and InterpMonotonicAngle alongside the existing interpolation icons.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding the monotonic cubic interpolation icon.
Linked Issues check ✅ Passed The change adds icon support for monotonic interpolation modes and fixes the crash cause implied by the issue.
Out of Scope Changes check ✅ Passed The patch is narrowly scoped to the animation track editor and directly supports the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Shakai-Dev Shakai-Dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VictorSohier
VictorSohier force-pushed the monotonic-cubic-bug-fix branch from a9bf86c to 1967b41 Compare July 29, 2026 14:38
@JoltedJon
JoltedJon merged commit b6bcbe5 into Redot-Engine:master Aug 1, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Animation Player | Setting interpolation mode of any track to Monotonic Cubic hard crashes Editor

3 participants