Perf: virtualize the transaction list over 200 rows - #1581
Merged
Baskarayelu merged 4 commits intoJul 30, 2026
Merged
Conversation
…changes Conflict resolution for PR Remitwise-Org#1581.
…changes Conflict resolution for PR Remitwise-Org#1581.
…changes Conflict resolution for PR Remitwise-Org#1581.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/dashboard/transaction-history/page.tsxalready hadreact-window-based virtualization written (FixedSizeList,TransactionVirtualRow) -- butreact-windowwas never added topackage.jsonand isn't innode_modulesat all, so the import silently failed to resolve. It was papered over with// @ts-ignoreon the import andconst List = FixedSizeList as any, which suppressed the type error but not the runtime module-resolution failure -- this page could not actually build.Adds
react-window(+@types/react-window) as real dependencies and removes the@ts-ignore/as anyworkarounds now that the types resolve properly (no prop mismatches -- the existingFixedSizeListusage already matched the real v1 API exactly).Testing
npx tsc --noEmit-- the page typechecks cleanly withreact-window's real types, no new errorsnode node_modules/vitest/vitest.mjs run ... tests/unit/dashboard/transaction-history-virtualization.test.tsx-- new test rendersFixedSizeListwith 250 rows and asserts only a subset ever mounts into the DOM (proof it's genuinely windowing, not just sitting in a scrollable container)npm run test:unit:vitest-- 298 passing (was 297 onmain), zero regressionsnpx eslinton both touched files -- cleanCloses #1490