Validate: reject invalid IBAN before submit - #1585
Merged
Baskarayelu merged 3 commits intoJul 30, 2026
Merged
Conversation
Conflict resolution for PR Remitwise-Org#1585.
Conflict resolution for PR Remitwise-Org#1585.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No IBAN field existed anywhere in the app. Adds
isValidIban()(lib/validation/iban.ts), a dependency-free ISO 13616 MOD-97-10 checksum validator (verified against well-known real IBAN test vectors from GB/DE/FR), and a new "Linked payout bank account" field inWalletSection(the natural home for anchor-withdrawal-adjacent settings) using the same reject-and-show-inline-error pattern as #1584's phone validation: an invalid IBAN shows arole="alert"error and skipstriggerSave(); empty is treated as valid since the field is optional.Also adds the
settings.wallet.payout_iban_invalidtranslation key toen.json/es.json, same scoped approach as #1584 -- not backfilling the rest of the pre-existing missingsettings.*tree.Testing
node node_modules/vitest/vitest.mjs run ... tests/unit/validation/iban.test.ts tests/unit/settings/WalletSection.test.tsx-- 9/9 pass (valid IBANs from 3 countries with/without spacing, case-insensitivity, empty-is-valid, bad checksum, structurally invalid, too-short, plus the component showing/clearing the error)npm run test:unit:vitest-- 306 passing (was 297 onmain), zero regressionsnpx eslinton all touched files -- cleannpx tsc --noEmit-- no new errors in any touched fileCloses #1472