Corrected sorting of routes #121 #127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@kpande here it is |
m42e
force-pushed
the
fix_routes_sort
branch
4 times, most recently
from
da69674 to
55fabac
Compare
Author
|
@augustohp Can you hava a look at the Scrutinizer, I've fixed the method to match the test results. |
|
@augustohp This PR also required for correct work on PHP >= 7. Because there is a difference in usort callback function that used in sortRoutesByComplexity method. |
Member
|
Not sure why scrutiniser has an issue with this. Don't feel confident enough that everything is on he up and up. |
Member
|
Closed: fixed sorting at 72cde63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #121