Repository navigation
Land #53 and #54 on main: namespaces + flattened layout - #55
Merged
Merged
Conversation
Apply the namespace rule from CLAUDE.md across the whole tree: - utils: d2bs::profiling -> d2bs::utils::profiling, d2bs::thread_utils -> d2bs::utils::threads, DeferGuard into d2bs::utils. - core: d2bs::config (core's) -> d2bs::core::config; detour, http, input, proxy, speedhack under d2bs::core. - lod114d: imports, hooks, asm_thunks and the console host under d2bs::lod114d; game/ stays d2bs::game. The imports/extras headers no longer inject aliases into d2bs::game - the game/ files that use them declare their own using-declarations. - runtime: d2bs::api -> d2bs::runtime::api; events (previously split between bare d2bs and a nested events namespace) -> d2bs::runtime::events; the script types -> d2bs::runtime::script; the generated .txt schema (TxtTables.h and its generator) moves from d2bs::game into d2bs::runtime::api::globals beside TxtLookup. - The contract keeps d2bs::game / d2bs::config. References are qualified minimally from the enclosing namespace. No behaviour change: the extracted JS API surface (api.json) is identical. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A Profiling.cpp comment still named thread_utils, and the tests' GameLoopCollaborators fake defined runtime::events / runtime::script members by qualified name from inside d2bs instead of opening their namespaces. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
With navigation and services folded into it, runtime is the only frontend, so the frontends/ grouping directory only added depth: - src/frontends/runtime -> src/runtime - src/glue -> src/dlls (the injectable DLL projects) - tests/frontends/runtime -> tests/runtime Paths only: project references and include directories, the solution, CI cache keys, .gitignore, extract_api.py / gen_txt_tables.py, the tests' .clang-tidy header filter, the fixture search path, and the docs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands #53 and #54 on
main.Both were squash-merged into their stacked base branches (#53 into
fold-navigation-services, #54 intoconsistent-namespaces) after #52 had already been merged intomain, so their changes never reachedmain. This PR carries the same reviewed commits, cherry-picked ontomain:d2bs::<project>::<subdirectory>(Make namespaces follow d2bs::<project>::<subdirectory> #53)src/runtime,src/dlls,tests/runtime(Flatten the source layout: src/runtime, src/dlls, tests/runtime #54)The resulting tree is byte-identical to
consistent-namespacesas merged (git diff origin/consistent-namespaces HEADis empty), so nothing here is unreviewed.🤖 Generated with Claude Code