Repository navigation
runtime: Control setters call into the game outside the handle lock - #74
Merged
Merged
Conversation
The control.state / control.disabled and control.cursorpos setters held the LockedHandle while calling Control::SetState / SetCursorPos. A backend may run those on the game thread and wait for it, which must not happen under the read lock, so the setters copy the handle out first and call it after the scope closes, as the text setter already does. docs/game_thread_safety.md lists SetState and SetCursorPos among the methods that can wait. Script-visible behaviour: none (1.14d resolves under its own lock). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
control.state/control.disabledandcontrol.cursorpossetters held theLockedHandlewhile callingControl::SetState/SetCursorPos. A backend may run those on the game thread and wait for it, which must not happen under the read lock, so the setters now copy the handle out and call it after the scope closes - the same shape the text setter already uses.docs/game_thread_safety.mdlists both among the methods that can wait.No script-visible change (1.14d resolves under its own lock).
Verification
build.ps1 Release(Win32, the 1.14d DLL): buildsbuild.ps1 test: 169/169 passbuild.ps1 check-format: clean🤖 Generated with Claude Code