Repository navigation
runtime: correct and complete a few binding docs - #76
Open
ResurrectedTrader wants to merge 1 commit into
Open
ResurrectedTrader wants to merge 1 commit into
ResurrectedTrader wants to merge 1 commit into
Conversation
- unit.revive() sends the player resurrect request (0x41), not a hireling revive. - clickMap names its click types (0 / 1 / 2 left down / held / up, 3 / 4 / 5 right down / held / up). - getMouseCoords() reports the screen space drawables use; screenToAutomap() takes game (world) coordinates despite its name and returns the automap's screen point. Doc comments only. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doc-comment-only fixes in the JS bindings (they feed the API docs and the d.ts):
unit.revive()sends the player resurrect request (0x41), not a hireling revive.clickMapnames its click types: 0 / 1 / 2 = left down / held / up, 3 / 4 / 5 = right down / held / up.getMouseCoords()reports the screen space drawables use;screenToAutomap()takes game (world) coordinates despite its name and returns the automap's screen point.Verification
build.ps1 Release(Win32, the 1.14d DLL): buildsbuild.ps1 test: 169/169 passbuild.ps1 check-format: clean🤖 Generated with Claude Code