test: Horizon duplicate-hash chaos with idempotency - #789
Open
Derekwalter999 wants to merge 1 commit into
Open
Conversation
|
@Derekwalter999 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #707 Stellar Horizon chaos: submit-endpoint duplicate-hash returns with idempotency assertion.
Context
When the Stellar submission worker encounters a timeout or is aggressively scaling, it might attempt to re-submit a transaction that has already been ingested by the network, resulting in a
DUPLICATEstatus response from the Horizon endpoint. Alternatively, a client-side bug could trigger an actual true-duplicate submission.Previously,
StellarSubmissionServicewould throw anErrors.conflictupon receiving this status. This PR modifies the service to treatDUPLICATEresponses as successes to prevent double-persisting, preserving idempotency without propagating a conflict error upstream.Changes Made
sendTransactionWithRetryblock to catchDUPLICATEresponses, immediately returning the pending/successful result to the caller instead of tossing a conflict exception.submission.duplicate.recoveredcounter metric viaglobalMetrics.increment()when a duplicate hash is gracefully recovered.src/__tests__/chaos/horizonDuplicateHash.test.tsto assert against:Security & Correctness Assumptions Validated
DUPLICATEresponse as a standard, already processed success.Checklist
submission.duplicate.recoveredmetric counter is actively emitted.