fix(chat): prevent duplicate message keys on first chat welcome message#1002
Merged
jaberjaber23 merged 1 commit intoRightNow-AI:mainfrom Apr 10, 2026
Merged
Conversation
jaberjaber23
approved these changes
Apr 10, 2026
Member
jaberjaber23
left a comment
jaberjaber23
left a comment
There was a problem hiding this comment.
LGTM. Local counter shadowed the global msgId, causing duplicate keys and rendering bugs on first chat.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the first chat session, the welcome message used a local id counter, while new user messages used the global message counter.
This could generate duplicate ids and cause key collisions in message list rendering, so the chat UI did not update correctly: both the new user message and assistant reply could be missing from the visible list until a page refresh.
Changes
Updated welcome message id generation to use the global message counter, preventing duplicate message ids.
Testing
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity