Skip to content

Support multiple pictures show, left and right sliding display#68

Open
jianminLee wants to merge 14 commits into
Riron:masterfrom
jianminLee:master
Open

Support multiple pictures show, left and right sliding display#68
jianminLee wants to merge 14 commits into
Riron:masterfrom
jianminLee:master

Conversation

@jianminLee

Copy link
Copy Markdown

sorry,my English is bad....
I have added more pictures to slide show。
It is necessary to explain here

  updateImageSrc(src) {
    if (Array.isArray(src)) {
      let srcLen = src.length;
      let safeImage: SafeUrl[] = [];
      for (let i = 0; i < srcLen; i++) {
        if(this.originalSrc === src[i]){
          this.imageCurIndex = i;
        }
        if(i === 0){
          this.imageChange = this._sanitizer.bypassSecurityTrustUrl(src[i]);
          safeImage = safeImage.concat(this.imageUrl);
          continue;
        }
        safeImage.push(this._sanitizer.bypassSecurityTrustUrl(src[i]));
      }
      this.imageUrl = safeImage;
    } else {
      this.originalSrc = src;
      this.imageUrl.push(this._sanitizer.bypassSecurityTrustUrl(src));
    }
  }

Because of the animation, I have to do a lot of operations here, if you choose a picture of a, I need to show that the effect of animation, and then slide to show before or after the picture, I really no better The way.

Use the same as before, just can be passed to the array or a single image URL.

Thank you again, this project is very helpful for my work, the animation is very cool, of course, the hope of the code for your project also help。

@Riron

Riron commented Jul 10, 2017

Copy link
Copy Markdown
Owner

Thanks for the PR 👍
That's a lot of code ! I will try to give it a look ASAP

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

is this support available now? How to use this feature?

@junyung1261

Copy link
Copy Markdown

how can fetch this

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

<img item-right src="{{post.imgSrc[0]}}" imageViewer="{{post.imgSrc}}">

Like a document, just an array is passed in

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

so is it possible to add ion-slide in imageViewer?. I mean its more like gallery where user cal slide images also and they can zoom?
is this support available?

@jianminLee

Copy link
Copy Markdown
Author

@Muneem
of course

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

How? Right now its only one image. I want to add ion-slide inside imageviewer

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

You have to use my pull request

start from specified image index when viewing multiple images
@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

@jianminLee ok then how would i use that feature? there is no documentation of how to use that feauture

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

See the author's document just fine, I just added a function, and this function only need you to the array, the above reply I have given the code

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

@jianminLee do you have working example of this feature?

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

There are examples in the author's document

<img item-right src="{{post.imgSrc[0]}}" imageViewer="{{post.imgSrc}}">

or

this.imageView.create(event.srcElement, {fullResImage: imgArr}).present();

imgArr and post.imgSrc can be an array or a string

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

@jianminLee i have provided array but its not showing me next images in slider. it is just opening that image where i am clicking

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

Are you sure you're using my pull request?

Please get the code here

https://github.com/jianminLee/ionic-img-viewer

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

How to use this as npm package? I have used npm install git+ your repo. but its giving me unmet peerdependency error

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

Posted an error message

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

screen shot 2017-08-17 at 4 33 18 pm

@jianminLee

Copy link
Copy Markdown
Author

@Muneem
This is the problem with the ionic framework. You can try running the program to see if it works, otherwise you can only upgrade your

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

@jianminLee i am using latest ionic configuration. All my things are latest. I think your branch is old so i have to downgrade few things to test this functionality

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

I'm sorry, I did not look at the wrong message carefully. I run in ionic-angular 3.6.0,
no problem

It applies to ionic-angular 3.6.0
@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

@jianminLee i downgraded my version. now its installed. but still its opening one image only. i have supplied imageViewer to my array but it is not showing me other images.

Synchronize with author version
@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

I found issue. I am passing array of images. And you are using this as src. You are not breaking it or yo are not considering it as array of images

@jianminLee

jianminLee commented Aug 17, 2017

Copy link
Copy Markdown
Author

@Muneem

I do not understand what you mean, can you put the complete code?

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

This is request object
these all are array object so it is appending all this in 1 request

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

one more thing can you please send me screenshot of what you have implemente?

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

have you check request object?screenshot which i have posted?

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

Post.imgSrc = ['http://xxxx.xxx/xxx.jpg','http://xxxx.xxx/xxx.jpg','http://xxxx.xxx/xxx.jpg','http: //xxxx.xxx/xxx.jpg '];

You can try to http://xxxx.xxx/xxx.jpg all replaced by a valid image url, look at the effect. Casually to google a few pictures of the url

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

Then like this:

      <ion-thumbnail item-right *ngIf="post.imgSrc.length">
        <img item-right src="{{post.imgSrc[0]}}" imageViewer="{{post.imgSrc}}">
      </ion-thumbnail>

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

@jianminLee can you please tell me how could i include this in ionic project? As through npm installl i am unable to include your branch in my ionic project

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

npm install https://github.com/jianminLee/ionic-img-viewer.git

This is not what?

@Muneem

Muneem commented Aug 17, 2017 via email

Copy link
Copy Markdown

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

If not, then I have no good idea, you can download directly to use

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

these all changes are present here: https://github.com/jianminLee/ionic-img-viewer

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

?

@jianminLee

Copy link
Copy Markdown
Author

@Muneem

Yes I will merge all the changes to the author

@Muneem

Muneem commented Aug 17, 2017

Copy link
Copy Markdown

@jianminLee one suggestion put it in master and generate new npm version also.

@junyung1261

Copy link
Copy Markdown

how can i get this branch?? im using ionic 3.9.2

@seiyria

seiyria commented Mar 18, 2018

Copy link
Copy Markdown

Currently it won't install because @jianminLee has an invalid semver version in the package.json. Sent a PR for that. Hopefully it will be merged, and hopefully that will get merged here!

@C1PR14N055

Copy link
Copy Markdown

+1, would be useful

Fix installation from non-registry
@LufoX11

LufoX11 commented May 8, 2018

Copy link
Copy Markdown

This is THE feature. It would be the best plugin if this kind of support would be added.

@AnthonyBillon

Copy link
Copy Markdown

Hi,
will this branch be merged with master ? I'm really interested by this feature !

@Shals08

Shals08 commented Jun 11, 2018

Copy link
Copy Markdown

Hi,
Am using "https://github.com/jianminLee/ionic-img-viewer/" to display the array of images by following your instructions. But there is one issue . InitialSlide attribute which am passing from my application based on user selection is not setting the image in the ion-slide immediately . There is a slight delay. Assume on clicking on the third image, am getting the first image for a second and then i get the proper image.

@jianminLee

Copy link
Copy Markdown
Author

@Shals08
look this issue!
ionic-team/ionic-framework#9819

@Shals08

Shals08 commented Jun 11, 2018

Copy link
Copy Markdown

@jianminLee
Thanks....
Oh issue in ionic :(.

@A7medHub

Copy link
Copy Markdown

This worked for me

 <ion-slides   *ngIf="images && images.length"   style="overflow: hidden" [autoplay]="2000" [loop]="true"  speed="1000">
      <div *ngFor="let mage of images ;let i = index">
        <ion-slide >
               <img src="{{mage}}"  (click)="itemSelected($event.target)" imageViewer  >
       </ion-slide>
      </div>
 </ion-slides>
import {ImageViewerController} from 'ionic-img-viewer';

 constructor(private imageViewerCtrl : ImageViewerController){
}
  itemSelected(imageToView) 
{
    const viewer = this.imageViewerCtrl.create(imageToView)
    viewer.present();
  }

@shally12

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.