Repository navigation
feat: Add ROS2TFClient test - #1292
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The skipped ROS 2 suite still opens a WebSocket during Vitest collection on Noetic runs, but its cleanup hook never runs, leaving the connection open.
1 open issue
What changed in this PR
Adds integration coverage for ROS2TFClient using the ROS 2 example environment, without changing the public API.
Changes:
- Adds a ROS 2 transform test that checks identity rotation and zero translation, with client and connection cleanup.
- Updates the static transform publisher to use named frame arguments.
| File | Description |
|---|---|
packages/roslib/test/examples/tf.example.ts |
Adds the ROS 2 transform test and cleanup hook. |
packages/roslib/test/examples/setup_examples_ros2.launch.xml |
Uses named arguments for the static transform’s parent and child frames. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
EzraBrooks
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Public API Changes
None
Description
Also fixes the arguments for static_transform_publisher call