Skip to content

feat: Add ROS2TFClient test - #1292

Merged
bjsowa merged 7 commits into
developfrom
feat/add-ros2-tf-test
Nov 5, 2026
Merged

bjsowa merged 7 commits into
developfrom
feat/add-ros2-tf-test

Conversation

@bjsowa

@bjsowa bjsowa commented Nov 4, 2026

Copy link
Copy Markdown
Member

Public API Changes
None

Description
Also fixes the arguments for static_transform_publisher call

Copilot AI balanced review requested due to automatic review settings November 4, 2026 22:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The skipped ROS 2 suite still opens a WebSocket during Vitest collection on Noetic runs, but its cleanup hook never runs, leaving the connection open.

1 open issue
What changed in this PR

Adds integration coverage for ROS2TFClient using the ROS 2 example environment, without changing the public API.

Changes:

  • Adds a ROS 2 transform test that checks identity rotation and zero translation, with client and connection cleanup.
  • Updates the static transform publisher to use named frame arguments.
File Description
packages/​roslib/​test/​examples/​tf.example.ts Adds the ROS 2 transform test and cleanup hook.
packages/​roslib/​test/​examples/​setup_examples_ros2.launch.xml Uses named arguments for the static transform’s parent and child frames.

Review effort: Balanced

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 4, 2026 22:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the ROS 2 transform-client test coverage and static publisher argument updates.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@bjsowa
bjsowa requested a review from EzraBrooks November 4, 2026 22:51
Copilot AI balanced review requested due to automatic review settings November 5, 2026 09:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Assertion failures in the transform callback leave the test promise pending, causing a timeout or allowing a later correct transform to mask the failure instead of rejecting immediately.

1 open issue

Review effort: Balanced

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 5, 2026 09:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the ROS 2 transform integration test and supporting launch configuration changes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 5, 2026 09:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the ROS 2 transform integration coverage changes.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 5, 2026 09:57
@bjsowa
bjsowa requested a review from MatthijsBurgh November 5, 2026 09:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block approval of the ROS 2 TF test and static transform publisher argument updates.

No open issues 🎉

Review effort: Balanced

@bjsowa
bjsowa merged commit a39e0d8 into develop Nov 5, 2026
15 checks passed
@bjsowa
bjsowa deleted the feat/add-ros2-tf-test branch November 5, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants