Repository navigation
feat: Allow running tests with external Rosbridge backend - #1293
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are blocking the external-backend testing change.
No open issues 🎉
What changed in this PR
This PR lets developers run roslibjs tests against a self-managed Rosbridge backend, making server development and debugging easier without changing the public API.
Changes:
- Adds
ROSLIB_EXTERNAL_BACKENDto skip container management while checking backend readiness. - Closes readiness-probe connections after each attempt so they do not keep Vitest running.
- Documents external-backend usage and matching
ROS_DISTROsettings.
| File | Description |
|---|---|
packages/roslib/test/setup/ros-backend.ts |
Adds external-backend setup and teardown handling, and closes probe connections. |
packages/roslib/README.md |
Documents the new option with a Docker-based example. |
Review effort: Balanced
MatthijsBurgh
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Makes it easier to test Rosbridge server against roslibjs during development