resolve missing unique key prop warnings in ChatInputFormattingToolbar#1118
resolve missing unique key prop warnings in ChatInputFormattingToolbar#1118Suraj704-glitch wants to merge 1 commit intoRocketChat:developfrom
Conversation
|
|
|
"I have submitted a fix for this issue in PR #1118. I've resolved the missing unique key warnings in the ChatInputFormattingToolbar and verified the fix in a live environment using open.rocket.chat. Ready for review!" |
|
@cla-assistant recheck |
|
Hi Team, I have already signed the CLA (as shown in the CLA assistant dashboard), but the status is still pending here. Since this is my first contribution, the workflows are also awaiting approval. Could a maintainer please approve the workflows to run the tests and verify the CLA status? I have fixed the "missing unique key prop" warnings in the ChatInputFormattingToolbar component and verified it in the live environment. Ready for review! Thanks! |
…oolbar
resolve missing unique key prop warnings in ChatInputFormattingToolbar
Acceptance Criteria fulfillment
Fixes # (issue) Fixes #1098
Screenshots
Evidence of Fix
I have attached screenshots showing the successful resolution of the React "missing key" warning.
Before Fix: The browser console displays a warning: Warning: Each child in a list should have a unique "key" prop, specifically pointing to the ChatInputFormattingToolbar.js component.

After Fix: Upon applying the stable keys and replacing unkeyed fragments, the console is clean and the ChatInput UI renders successfully without any reconciliation warnings.

PR Test Details
Launched the environment using yarn storybook.
Logged in using https://open.rocket.chat as the host to mount the ChatInput component.
Inspected the Browser Console (F12) to confirm that the yellow "unique key prop" warning no longer appears when the toolbar renders.
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-1118 after approval. Contributors are requested to replace
#1118with the actual PR number.