fix: show users list when names array is empty

[deepak0x]

This PR fixes an issue where the list of users reacting to a message was not displayed when switching to an emoji-specific tab in the reaction modal.

---

Issue(s)

Closes #6540

---

How to test or reproduce

1. React to any message with an emoji.
2. Long-press the reaction emoji to open the reactions modal.
3. Switch to an emoji-specific tab (not All).
4. Verify that the list of users who reacted is displayed correctly.

---

Screenshots

Before vs After

Before (Bug)	After (Fixed – 1)	After (Fixed – 2)

---

Additional Screenshots

After – Reaction List (1)	After – Reaction List (2)

---

Types of changes

• Bugfix (non-breaking change which fixes an issue)

---

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (not applicable)
• I have added necessary documentation (not applicable)
• Any dependent changes have been merged and published in downstream modules

[coderabbitai]

Walkthrough

Fixed a bug in ReactionsList rendering where the UsersList failed to display on the second tab. The renderScene condition now properly validates that usernames exist with length greater than 0, and provides a safe default empty array for names.

Changes

Cohort / File(s)	Summary
ReactionsList rendering condition app/containers/ReactionsList/index.tsx	Updated renderScene condition to check route.usernames.length > 0 instead of only truthy check; provides route.names || [] default to ensure names is always defined

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tab that once sat empty and bare,
Now shows all the reactions with care!
With proper checks in place,
The UsersList finds its space—
No more users lost in thin air! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly addresses the fix: making the users list display when the names array is empty, which matches the core change in the code.
Linked Issues check	✅ Passed	The code changes directly fix issue #6540 by updating the rendering condition to not require names to be present and defaulting it to an empty array.
Out of Scope Changes check	✅ Passed	All changes are focused on the ReactionsList component to fix the specific bug; no unrelated modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Rohit3523]

As mentioned in #6540 (comment), I have a question, what happens if the workspace has enabled Show real name in the workspace settings but the real name is missing in websocket which will forces the app to display the username?

correct me if i am wrong

[deepak0x]

yes correct
it is already set in app i didn't change it

[Rohit3523]

I tried to reproduce this issue and found one possible cause using the following steps

1. Go to any user DM or channel
2. Open the same room on another device using a different account
3. React to any message from the second device
4. On the first device, long-press the emoji to open the reaction list
5. Observe that only the username is shown instead of the real name because the name field is missing in the WebSocket payload

[deepak0x]

let me try too

[deepak0x]

hey i checked its working fine in dm and channels too