Improve icon font initial page load state #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scriswell
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
According to recommendations here https://developers.google.com/fonts/docs/material_symbols#optimize_the_icon_font we should be using the display block option to prevent the icon text from rendering during load. See https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face/font-display for details on what this setting actually does.
What Changed
&display=blockto icon font importSanity Check
[ ] Have you updated any usage of changed tokens?[ ] Have you updated the docs with any component changes?[ ] Have you updated the dependency graph with any component changes?[ ] Do you need to update the package version?