Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Reviewed the preview environment documentation updates. Found 1 issue:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
Comment on lines
+353
to
356
| app.register(import('@fastify/cors'), { | ||
| origin: process.env.ROO_WEB_HOST || 'http://localhost:3000' | ||
| }); | ||
| ``` |
Contributor
There was a problem hiding this comment.
The inline dynamic import pattern import('@fastify/cors') returns a Promise resolving to a module namespace object ({ default: ... }), not the plugin function directly. This may not work as expected with Fastify's register method. The standard pattern from Fastify's documentation is:
Suggested change
| app.register(import('@fastify/cors'), { | |
| origin: process.env.ROO_WEB_HOST || 'http://localhost:3000' | |
| }); | |
| ``` | |
| import cors from '@fastify/cors'; | |
| app.register(cors, { | |
| origin: process.env.ROO_WEB_HOST || 'http://localhost:3000' | |
| }); |
Fix it with Roo Code or mention @roomote and request a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Update preview environment documentation to include detached commands, tool version management, and environment variable usage.
Detached Commands,Tool Versions,misetoenvironments.mdx.detached: trueinstead of&inenvironments.mdx.logfileoption for detached commands inenvironments.mdx.ROO_<NAME>_HOSTvariables for service communication.ROO_API_HOSTto.envfiles for frameworks using dotenv..tool-versionswithmiseinenvironments.mdx.This description was created by
for bbebc1e. You can customize this summary. It will automatically update as commits are pushed.