fix: parallel tool call failure counter increments once per batch (EXT-728)

[roomote]

When parallel tool calls are executed and all of them fail, the failure counter should increment by 1, not by the number of failed tools. This prevents the "Roo is having trouble" error from appearing prematurely.

Problem

When parallel tool calls are made (e.g., 3 tools in a single API response), each tool failure increments consecutiveMistakeCount independently. If all 3 tools fail, the counter goes up by 3 instead of 1, causing the mistake limit to be reached prematurely.

Solution

Treat parallel tool calls as a batch for failure counting purposes:

• Save the mistake count at batch start
• Track if any tool succeeds in the batch
• After all tools complete, reconcile:
  • If any tool succeeded: counter stays at 0
  • If all tools failed: increment by 1 from batch start (not N failures)

Changes

• Add consecutiveMistakeCountAtBatchStart and parallelToolSuccessInBatch tracking fields to Task.ts
• Add recordToolSuccess() helper method that marks batch success and resets the mistake counter
• Initialize batch tracking at the start of each API request
• Add batch reconciliation logic after all tools complete
• Update all tool handlers to use recordToolSuccess() instead of directly setting consecutiveMistakeCount = 0
• Add comprehensive tests for the new behavior

Expected Behavior

After the fix:

• If 3 parallel tools are called and all fail → counter increments by 1
• If 3 parallel tools are called and 1 succeeds → counter resets to 0
• Sequential tool calls continue to work as before (each batch is independent)

Linear issue: https://linear.app/roocode/issue/EXT-728/roo-is-having-trouble-on-parallel-tool-calls

---

View task on Roo Code Cloud

---

Important

Fixes parallel tool call failure counter to increment once per batch, with updates to Task.ts and comprehensive tests added.

• Behavior:
  • Fixes failure counter for parallel tool calls to increment by 1 per batch instead of per tool failure.
  • Adds consecutiveMistakeCountAtBatchStart and parallelToolSuccessInBatch fields to Task.ts.
  • Introduces recordToolSuccess() method in Task.ts to mark batch success and reset the mistake counter.
  • Updates tool handlers to use recordToolSuccess() instead of directly setting consecutiveMistakeCount = 0.
• Batch Processing:
  • Initializes batch tracking at the start of each API request in Task.ts.
  • Adds batch reconciliation logic in Task.ts to adjust the mistake counter after all tools complete.
• Testing:
  • Adds parallel-tool-failure-counter.spec.ts with comprehensive tests for the new behavior.

^{This description was created by for eb0dae6. You can customize this summary. It will automatically update as commits are pushed.}

[roomote]

Rooviewer   See task on Roo Cloud

Review completed. The implementation correctly fixes the parallel tool call failure counter issue. One minor suggestion for improving test clarity:

• Consider renaming test at line 146 to better reflect expected behavior (counter = 1, not 0)

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

[roomote]

The test name says "should keep counter at 0" but the actual assertion expects 1. The test behavior and comments are correct, but the name is misleading.

Suggested change

	it("should keep counter at 0 when 1 tool succeeds and 2 fail", () => {
	it("should not reconcile counter when at least one tool succeeds (even if failures follow)", () => {

_{Fix it with Roo Code or mention @roomote and request a fix.}