fix: truncate long MCP server names with tooltip on hover#11189
Draft
roomote[bot] wants to merge 1 commit intomainfrom
Draft
fix: truncate long MCP server names with tooltip on hover#11189roomote[bot] wants to merge 1 commit intomainfrom
roomote[bot] wants to merge 1 commit intomainfrom
Conversation
- Add text truncation styles (overflow, text-overflow, white-space) to server name - Wrap server name span in StandardTooltip to show full name on hover - Add flexShrink: 0 to buttons container to prevent it from being pushed out Fixes #11188
Contributor
Author
Review complete. No issues found. The implementation correctly addresses the truncation issue using standard CSS techniques and existing components. Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #11188
Description
This PR attempts to address Issue #11188. When users have long MCP server names configured, the name pushes the refresh, delete, and toggle buttons out of the visible window area.
Changes made:
overflow: hidden,textOverflow: ellipsis,whiteSpace: nowrap,minWidth: 0) to the server name span to properly truncate long namesStandardTooltipcomponent to show the full name on hover when truncatedflexShrink: 0to the buttons container to prevent action buttons from being pushed out of viewFeedback and guidance are welcome.
Test Procedure
Pre-Submission Checklist
Documentation Updates
Additional Notes
The fix uses the existing
StandardTooltipcomponent which is already imported and used elsewhere in the MCP view. All tests pass and TypeScript type checking completes without errors.Important
Truncates long MCP server names with ellipsis and adds tooltips for full names in
McpView.tsx, ensuring buttons remain visible.ServerRowinMcpView.tsx.StandardTooltip.flexShrink: 0to their container.overflow: hidden,textOverflow: ellipsis,whiteSpace: nowrap,minWidth: 0to server name span inServerRow.This description was created by
for e989cc0. You can customize this summary. It will automatically update as commits are pushed.