ci(cypress): prepare dedicated nightly pipeline#1737
Conversation
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughCircleCI continuation routing now uses ChangesCircleCI updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant DetectScript as detect-cypress-defer.sh
participant GitHubAPI as GitHub PR API
participant PipelineParams as pipeline-parameters.json
DetectScript->>GitHubAPI: Poll PR labels
GitHubAPI-->>DetectScript: Return open PR labels and creation time
DetectScript->>PipelineParams: Write defer_cypress decision
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Prepares a dedicated CircleCI nightly-cypress pipeline by renaming the shared continuation config to .circleci/workflows.yml, keeping job/executor definitions shared across pipelines, and documenting the intended responsibilities and migration steps.
Changes:
- Update the setup continuation to load
.circleci/workflows.yml(instead of the prior shared continuation config path). - Add
.circleci/README.mddocumentingCI,nightly-cypress, anddeploypipelines plus safe migration order. - Update internal docs/references to point to the new workflows config file.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/deploy.md | Updates release artifact documentation to point at the tag workflow location in the shared CircleCI workflows config. |
| AGENTS.md | Adds guidance to read .circleci/README.md before modifying CircleCI pipelines/paths/schedules. |
| .circleci/workflows.yml | Minor comment update clarifying that the nightly workflow is scheduled via the dedicated pipeline. |
| .circleci/README.md | New CI documentation describing pipeline responsibilities and migration/safety steps. |
| .circleci/config.yml | Updates continuation configuration_path to .circleci/workflows.yml. |
RoundingWell Care Ops Frontend
|
||||||||||||||||||||||||||||
| Project |
RoundingWell Care Ops Frontend
|
| Branch Review |
feature/fe-181-separate-nightly-cypress-into-its-own-circleci-pipeline
|
| Run status |
|
| Run duration | 01m 57s |
| Commit |
|
| Committer | Paul Falgout |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
1
|
|
|
0
|
|
|
0
|
|
|
240
|
| View all changes introduced in this branch ↗︎ | |
0376dc2 to
c12f4b0
Compare
There was a problem hiding this comment.
cubic analysis
All reported issues were addressed
Linked issue analysis
Linked issue: FE-181: Separate nightly Cypress into its own CircleCI pipeline
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Rename continuation config to .circleci/workflows.yml and update configuration_path in .circleci/config.yml | The PR renames the shared continuation config and updates the config reference so dynamic continuation points at the new path. |
| ✅ | Move shared workflows into .circleci/workflows.yml and keep Cypress jobs/executors defined once for CI and nightly | The shared workflows file is present and the PR keeps the same job/executor definitions while selecting nightly vs normal workflows via pipeline.trigger_source. |
| ✅ | Add .circleci/README.md documenting CI, nightly-cypress, and deploy responsibilities and the safe migration order | A README describing the three pipelines, the schedule timing, and the rollout steps was added in the PR. |
| ✅ | Improve detect-cypress-defer.sh to poll for the defer label and handle API-read failures | The script was updated to retry/poll for labels attached shortly after PR creation and to fall back if the API cannot be read. |
| ✅ | Update repository docs to reference the renamed shared workflows file | Docs referencing the config/workflows path were updated to point at .circleci/workflows.yml. |
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
c12f4b0 to
04f5a3b
Compare
Coverage Report for CI Build 25Coverage remained the same at 100.0%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
nmajor25
left a comment
There was a problem hiding this comment.
Just one thing claude found, not sure if it's legit.
04f5a3b to
6f2640e
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.circleci/detect-cypress-defer.sh:
- Around line 23-32: Add explicit connection and overall operation timeouts to
the curl invocation in the GitHub API request block, alongside the existing
--retry option. Keep the current retry, headers, output handling, and failure
branch unchanged while ensuring stalled requests cannot block the PR-label
polling flow indefinitely.
- Around line 36-56: Update the jq parsing blocks that assign defer_cypress and
should_poll to detect command failure instead of allowing set -e to terminate
the script. When either parse fails, set api_read_succeeded=false and break so
the existing default Cypress behavior and output-file handling can run.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 36f0ee57-daef-4144-bcef-a72b2acb3bc9
📒 Files selected for processing (6)
.circleci/README.md.circleci/config.yml.circleci/detect-cypress-defer.sh.circleci/workflows.ymlAGENTS.mddocs/deploy.md
🚧 Files skipped from review as they are similar to previous changes (5)
- .circleci/README.md
- AGENTS.md
- .circleci/workflows.yml
- .circleci/config.yml
- docs/deploy.md
6f2640e to
0454005
Compare
Closes FE-181
What
.circleci/workflows.yml.CI,nightly-cypress, anddeploypipeline responsibilities and safe migration order.ci:defer-cypresswins the PR-created event race.Why
Nightly Cypress is operationally separate from PR, branch, tag, and release CI. A dedicated pipeline makes that ownership visible without duplicating the Cypress configuration.
The first live run also showed that CircleCI setup could finish before PR automation attached
ci:defer-cypress, starting Cypress despite the intended review hold.Scope
CircleCI configuration and repository CI documentation only. Cypress commands, recording, parallelism, coverage, notifications, and deploy behavior are unchanged.
Only newly opened PRs receive the short label grace period. Existing human PR revisions without the label continue immediately.
The live CircleCI pipeline definitions and schedule remain unchanged until this PR merges.
Deployment Impact
No application or form redeploy is required.
After merge, CircleCI Project Setup must be updated to:
app-frontendtoCI.Test-releaseasnightly-cypressand point it to.circleci/workflows.yml.deploy-pipelinetodeploy.developschedule tonightly-cypress.Testing
circleci config validate .circleci/config.ymlcircleci config validate .circleci/workflows.yml.circleci/workflows.ymlwithdefer_cypressset to bothfalseandtrue.bash -n .circleci/detect-cypress-defer.shdefer_cypress: true.developproduceddefer_cypress: false.npm run lintgit diff --checkCurrent-commit CircleCI passed lint, E2E, component, and Coveralls after the approval gate; Cypress Cloud reports 240 E2E tests passed.
Summary by CodeRabbit
Bug Fixes
Documentation