Tweak zeroization#343
Merged
Merged
Conversation
Merged
newpavlov
added a commit
that referenced
this pull request
Jul 8, 2026
tarcieri
reviewed
Jul 16, 2026
Comment on lines
-168
to
-173
| #[cfg(feature = "zeroize")] | ||
| impl Zeroize for FieldElement { | ||
| fn zeroize(&mut self) { | ||
| self.0.zeroize(); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This was a breaking change, as FieldElement is part of the public API: https://github.com/RustCrypto/AEADs/actions/runs/29241312311/job/86787771717?pr=858#step:4:84
tarcieri
added a commit
that referenced
this pull request
Jul 16, 2026
This was removed in #343 but is part of the public API, which lead to downstream breakages: https://github.com/RustCrypto/AEADs/actions/runs/29241312311/job/86787771717?pr=858#step:4:84
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes simplify zeroization code and fix the (technically) unsound zeroization in
poly1305.Closes #342