feat(telemetry): discover companion SDK resource attributes via entry points - #288
Draft
jeanscherf wants to merge 3 commits into
Draft
feat(telemetry): discover companion SDK resource attributes via entry points#288jeanscherf wants to merge 3 commits into
jeanscherf wants to merge 3 commits into
Conversation
… SDKs Adds a module-level registry in create_resource_attributes_from_env() so companion SDKs (e.g. sap-internal-sdk) can contribute their version as an OTel resource attribute at import time, without requiring any change to agent startup code.
Remove the import-time registry (_extra_sdk_attributes / register_sdk_resource_attributes) and replace it with importlib.metadata entry_points discovery at auto_instrument() call time. Any installed package that registers a callable under the "sap_cloud_sdk.resource_providers" group has its returned dict merged into the resource attributes automatically — no import order dependency, no agent code change required.
jeanscherf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
register_sdk_resource_attributes/_extra_sdk_attributes) withimportlib.metadataentry-points discoverycreate_resource_attributes_from_env()now callsentry_points(group="sap_cloud_sdk.resource_providers")at OTel init time (insideauto_instrument())pyproject.tomlunder[project.entry-points."sap_cloud_sdk.resource_providers"]Test plan
uv run pytest tests/core/unit/telemetry/test_config.py— 32 tests passsap.internal_sdk.versionappears in resource attributes after installingsap-internal-sdkalongside this change (covered by companion PR https://github.tools.sap/application-foundation/sap-internal-sdk-python/pull/48)