fix: handle MCPError import with fallback for mcp version compatibility - #298
Merged
Merged
Conversation
jplbrun
approved these changes
Sep 1, 2026
ricardosrib
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
mcplibrary renamedMcpErrortoMCPErrorin an intermediate version range. This caused anImportErrorat startup for consumers using thosemcpversions:The fix adds a
try/except ImportErrorfallback in both_customer.pyand_lob.pyso the SDK works across allmcpversions: it tries the current name (McpError) first, and falls back toMCPErrorfor the intermediate version range where it was renamed.Related Issue
N/A
Type of Change
How to Test
sap-cloud-sdkwith a version ofmcpthat exportsMCPErrorinstead ofMcpErrorfrom sap_cloud_sdk.agentgateway import create_clientImportErrorat import timeChecklist
Breaking Changes
None.
Additional Notes
The
# ty: ignore[unresolved-import]comment on the fallback line suppresses the static type checker error forMCPError(which doesn't exist in the locally pinnedmcpversion but does exist in the intermediate version range that triggered this issue).