Improve QR generator UX - #1
Open
fwextensions wants to merge 1 commit into
Open
Conversation
- Block HTTP URLs: only https:// is now accepted; error message updated accordingly - Hide preview on input change: typing in the URL field immediately clears any existing QR code so users don't mistake a stale code for the current URL - Size buttons re-render immediately: after a code has been generated, clicking a different size regenerates the QR code at that size without requiring a second click of Generate - Enter key support: pressing Enter in the URL field triggers generation when the URL is valid - Keyboard focus ring on size buttons: uses :focus-visible on the label via has() so the blue outline appears during keyboard navigation but not on mouse click
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
:focus-visibleon the label viahas()so the blue outline appears during keyboard navigation but not on mouse click