feat(vscode): add test recognition to vscode - #5019
Merged
Merged
Conversation
benfdking
force-pushed
the
adding_testing_to_vscode
branch
2 times, most recently
from
July 28, 2025 15:33
217e04c to
d0af399
Compare
benfdking
commented
Jul 28, 2025
benfdking
left a comment
Contributor
Author
There was a problem hiding this comment.
Small tweaks to improve
benfdking
force-pushed
the
adding_testing_to_vscode
branch
from
July 28, 2025 17:20
d0af399 to
5c3eebc
Compare
benfdking
marked this pull request as ready for review
July 28, 2025 17:20
benfdking
force-pushed
the
adding_testing_to_vscode
branch
from
July 28, 2025 17:29
5c3eebc to
b0ad05b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds test recognition and execution capabilities to the VS Code extension, enabling users to discover, view, and run SQLMesh tests directly within the editor's test runner interface.
- Implements LSP methods for listing workspace tests, document-specific tests, and running individual tests
- Adds VS Code test controller integration to display tests in the Test Explorer panel
- Creates test range detection functionality to provide accurate line number mappings for test entries
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| vscode/extension/tests/tests.spec.ts | End-to-end test for the new test functionality |
| vscode/extension/src/tests/tests.ts | Main test controller implementation for VS Code |
| vscode/extension/src/lsp/lsp.ts | Type casting fix for error handling |
| vscode/extension/src/lsp/custom.ts | TypeScript interface definitions for new LSP methods |
| vscode/extension/src/extension.ts | Integration of test controller into the extension |
| tests/lsp/test_context.py | Unit tests for LSP context test methods |
| sqlmesh/lsp/tests_ranges.py | YAML parsing utility for extracting test ranges |
| sqlmesh/lsp/main.py | LSP server handlers for test-related methods |
| sqlmesh/lsp/custom.py | Python class definitions for LSP test methods |
| sqlmesh/lsp/context.py | Core test discovery and execution logic |
1 task
benfdking
force-pushed
the
adding_testing_to_vscode
branch
from
July 28, 2025 21:20
52a2520 to
d1dce74
Compare
benfdking
enabled auto-merge (squash)
July 28, 2025 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.