Enforce LF line endings via .gitattributes and normalize existing files#550
Open
SRombauts wants to merge 4 commits into
Open
Enforce LF line endings via .gitattributes and normalize existing files#550SRombauts wants to merge 4 commits into
SRombauts wants to merge 4 commits into
Conversation
Declare `* text=auto eol=lf` so git normalizes line endings on commit and checkout regardless of contributor OS, editor, or tooling, matching the existing .editorconfig policy (end_of_line = lf). Mark *.db3 and *.png as binary so they are never normalized. Cross-reference the enforcement in the sqlitecpp-coding-standards skill.
Re-normalize the two unit test files that were committed with CRLF, per the new .gitattributes policy. No content changes (eol only).
Re-normalize meson_options.txt, the example2 CMakeLists.txt, the SQLiteCppConfig.cmake.in template, and subprojects/.gitignore, which were committed with CRLF/mixed endings. No content changes (eol only).
Re-normalize README.md, the example and sqlite3 README files, LICENSE.txt, and the Copilot instructions, which were committed with CRLF/mixed endings. No content changes (eol only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo declares
end_of_line = lfin.editorconfig, but nothing enforced it at the git level (no.gitattributes,core.autocrlf=false). As a result, 12 tracked files had drifted to CRLF or mixed line endings in the committed blobs, in violation of the policy.This PR adds the missing enforcement and normalizes the offenders.
Changes (one theme per commit)
.gitattributes—* text=auto eol=lfso git normalizes line endings on commit/checkout regardless of contributor OS, editor, or tooling;*.db3/*.pngmarkedbinary. Also cross-references the enforcement in thesqlitecpp-coding-standardsskill.tests/Database_test.cpp,tests/Transaction_test.cpp.meson_options.txt,examples/example2/CMakeLists.txt,cmake/SQLiteCppConfig.cmake.in,subprojects/.gitignore.README.md,examples/example1/README.md,examples/example2/README.md,sqlite3/README.md,LICENSE.txt,.github/copilot-instructions.md.Notes for review
git show <sha> --ignore-all-space(empty diff) orgit log --oneline master..HEAD.git add --renormalize .reports nothing — the tree is fully consistent with.editorconfig.README.md; if Add CI workflow computing test & example code coverage (GCov + Coveralls) #549 merges first this stays trivially mergeable since the changes are disjoint (badge line vs. whole-file eol).