Add Certificate Authority functionality for AD

[krishnavema]

Implement certificate authority for AD

[spoore1]

This is a great start and as I mentioned earlier my main initial concern is around the request()/request_smartcard() methods.

My main thought here is to make request() align more closely with what you wrote for the IPA one so we can abstract it out to the GenericProvider later. I think the current request() could be made request_enrollment() and request_smartcard() renamed to request with some minor changes.

You might also consider a method to generate the INF file based on some basic input like template, subject, keysize. Then use template to select which set of configs to use for the INF based on that.

[danlavu]

Overall, this looks great, with a few minor nitpicks and a couple of larger requested changes.

[danlavu]

@krishnavema I'm sorry, I did review this before I left for PTO but I didn't click submit review.

[spoore1]

Another glance and it's looking very good. Just a question about the PSIni module calls you have in the request methods. I can't seem to find those.

[danlavu]

This is great, nitpicks and missing unit tests for the misc functions.

[danlavu]

I haven't tested it, but besides the single nitpick, I think this looks great. It does need to be tested; tentative approval until Scott or I can test it.

[danlavu]

Tentative approval, will finish the approval after I test it.

[spoore1]

Some notes after trying to test.

1. I believe the __request_enrollment() method in AD may not be necessary.

Most (if not every) smart card certificate case we'll need to cover will require an Enrollment Agent certificate because we're using Administrator to request certificates for other users. In this case, we could just create a default enrollment agent certificate for Administrator during the AD environment setup (still TBD). If we do this, we can simply have a method to get the hash for it that can be used inside of the request() method instead of passing it in to that method.

If you want to keep the code to generate the enrollment agent certificate, I would suggest making __request_enrollment() called only once during class init() or __setup() since we only need one enrollment certificate to issue other certificates.

2. I think request() will be used far more than request_basic() so the latter may not be necessary either.

Since request() is what should be in the generic class, and we don't have a request_basic() for IPA, I don't think we'll need this (at least for smart card testing). If you want to keep it around for other potential usage later, I'm ok with that. It should be noted though that currently running requst_basic() even with a user name specified for the subject will return a certificate with subject = CN=Administrator. That's why we have to use the "Enroll On Behalf Of" functionality to get "CN=username" for the issued certificate's subject.

[spoore1]

Updates from test findings.

[spoore1]

Ok, after a lot of digging and working through some test environment issues, I got a good test with the following changes I suggest. I'll send more info directly on some test env setup changes you'll need to make as well.

[spoore1]

I think there are some places you might be able to simplify the code a little and make it easier to read like:

• use of raise_on_error=False with result checks instead of relying on raising an exception in the host.conn.run() failures.
• indentation of some of the powershell code. maybe we can move the content into variables indented and use textwrap.dedent() to make it a little easier to read?

I'd like to get feedback from you and @danlavu on some of those points. Overall it looks good. My tests are working with this code as it is now so that's awesome!

[spoore1]

This PR is looking good. I only have one thing for this time but, I'll be discussing more with @danlavu tomorrow.

[danlavu]

Looks good, the identical parser functions I'd like to clarify on, would like to start the discussion to determine the differences for ipa.

[danlavu]

Thanks for the big patch, good stuff.

[spoore1]

LGTM. I was able to test the code with some additional setup on AD and with DNS updates in sssd-ci-containers that is in progress now. Also it should be noted that in order to test properly with Kerberos I had to change the crypto policy on the client to allow SHA1 for AD.

Tested with a slightly modified version of test mentioned elsewhere:

tests/test_ad.py::test_ad__certificate_authentication_basic (ad) PASSED

I'm holding off approving until the test issue is resolved. I believe you just need to rebase with master to fix the issue though. After that and letting the tests run again, I believe I'll be able to approve and merge this.

[spoore1]

LGTM. All tests now passing after rebase. Thank you!