🐛 Fix monthly leaderboard and sorting users#1555
Open
jernejk wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the “Monthly” leaderboard calculation so it reflects recent activity (rolling 30-day window) instead of calendar month-to-date, preventing the leaderboard appearing effectively empty early in a month.
Changes:
- Update
LeaderboardServiceto computePointsThisMonthusing a rolling last-30-days UTC window. - Keep existing weekly rolling-window behavior and yearly calendar-year behavior unchanged.
- Add a unit test validating the January boundary case (late-December counts for Monthly but not Yearly).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Application/Leaderboard/LeaderboardService.cs |
Changes monthly points aggregation from calendar-month filter to a 30-day rolling UTC range. |
tests/Application.UnitTests/Leaderboard/LeaderboardServiceTests.cs |
Adds coverage for the rolling-month behavior across a year boundary while preserving yearly semantics. |
jernejk
changed the title
jernejk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boss reported that the Monthly mobile leaderboard was effectively empty early in the month. The API treated
ThisMonthas calendar-month-to-date, so on May 2 it only looked at roughly 2 days instead of the expected recent month of activity.Changed
LeaderboardServicesoPointsThisMonthuses a rolling 30-day UTC window.PointsThisYearis still calendar-year based, and the existing weekly rolling 7-day behavior is unchanged.Also stabilized leaderboard sorting across the API paths. Period leaderboards now sort by selected period points, then name. All-time ranking is also stable by total points, then name. This avoids tied scores falling back to arbitrary cached/DB result order while keeping the query simple.
Validation:
MSBuildEnableWorkloadResolver=false dotnet test tests/Application.UnitTests/Application.UnitTests.csproj --no-restorepassed 61/61MSBuildEnableWorkloadResolver=false dotnet build src/WebAPI/WebAPI.csprojsucceededThe environment is missing the pinned .NET workload set
10.0.103, so the workload resolver had to be disabled for the local run.Worked with Codex.