CSHARP-65: Removed background color from icon on secondary navigation#24
Merged
buttonwillowsix merged 3 commits into1.xfrom Feb 20, 2026
Merged
CSHARP-65: Removed background color from icon on secondary navigation#24buttonwillowsix merged 3 commits into1.xfrom
buttonwillowsix merged 3 commits into1.xfrom
Conversation
buttonwillowsix
requested changes
Feb 20, 2026
Contributor
buttonwillowsix
left a comment
buttonwillowsix
left a comment
There was a problem hiding this comment.
Longer term, let's make this a bit more elegant by making the BG color for a::after less broad so we don't have to override it.
Shorter term, let's make sure that the ::after for .su-link--external is also green, and then I will merge and cut a release.
* Refactor MenuItem to improve submenu rendering logic Update MenuItem component to conditionally render caret and submenu based on child items instead of expanded prop. * compile * respect expanded --------- Co-authored-by: Mike Decker <pookmish@stanford.edu>
buttonwillowsix
approved these changes
Feb 20, 2026
Contributor
buttonwillowsix
left a comment
buttonwillowsix
left a comment
There was a problem hiding this comment.
External link icons fixed. Other zany issue fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
6.2.0release.Criticality
Urgency
Review Tasks
Setup tasks and/or behavior to test
drush cr ; drush ciSite Configuration Sync
Front End Validation
Backend / Functional Validation
Code
Code security
General
Affected Projects or Products
Associated Issues and/or People
- CSHARP-65
@mentionthem here)Resources