Skip to content

Refactor MenuItem to improve submenu rendering logic #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buttonwillowsix merged 3 commits into from
Feb 20, 2026
Merged

Refactor MenuItem to improve submenu rendering logic #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
643e66d
Refactor MenuItem to improve submenu rendering logic
buttonwillowsix Feb 20, 2026
5ca2056
compile
pookmish Feb 20, 2026
19d9ece
respect expanded
pookmish Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion decoupled-menu/dist/islands/main-menu.island.umd.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 9 additions & 2 deletions decoupled-menu/src/main-menu.island.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,12 @@ const ListItem = styled.li<{ level?: number }>`
}
`

/**
* Renders a single menu item (link and optional submenu).
* The caret and submenu are shown only when this item has children (items.length > 0).
*/
const MenuItem = ({id, title, url, items, expanded, level = 0}: {
id: string
title: string,
url: string,
items?: MenuContentItem[],
Expand Down Expand Up @@ -403,7 +408,8 @@ const MenuItem = ({id, title, url, items, expanded, level = 0}: {
<NoLink>{title}</NoLink>
}

{(items && expanded) &&
{/* Show caret only when this item has child menu items (not based on expanded). */}
{items && items.length > 0 && expanded &&
<>
<Button
ref={buttonRef}
Expand All @@ -422,7 +428,8 @@ const MenuItem = ({id, title, url, items, expanded, level = 0}: {
}
</MenuItemContainer>

{(items && expanded) &&
{/* Render submenu only when this item has children; open state is controlled by submenuOpen. */}
{items && items.length > 0 && expanded &&
<MenuList open={submenuOpen} level={level}>

{items.map(item =>
Expand Down
1 change: 1 addition & 0 deletions decoupled-menu/src/tools/build-menu-tree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ export interface MenuContentItem {
parent: string
items?: MenuContentItem[]
weight: number
expanded: boolean
}

export const buildMenuTree = (links: MenuContentItem[], parent = ""): { items?: MenuContentItem[] } => {
Expand Down