Repository navigation
Add child working directories and durable parent loop wakeups - #1211
Merged
SamSaffron merged 2 commits intoOct 6, 2026
Merged
Conversation
Address the existing Astra and Opus reviews of PR SamSaffron#1211. Preserve normal parent tools/settings, synthetic internal provenance, durable admission and reload acknowledgments, explicit stop intent, and uncollected media. Keep native children free of execution deadlines; 0–3600 second waits bound caller collection only and the configured/default 500 turns remain the execution budget. Synchronize the reproduced Telegram deferred-cleanup test race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Continue the native
spawn_agentmigration gaps on basea2737d6b; this does not route native execution through jobs-v2.cwd: inherit the parent's actual directory by default; resolve relative paths there; require an existing directory; persist the resolved path for continuation without widening workspace/approval authority.notify_when_done: reactivate the original parent agent loop, not emit a raw child report. Delivery is currently supported only for persisted web parents; Telegram, terminal chat, ask, and sessionless hosts explicitly reject the option.continue_agent; recovery requires a subsequent user-authorized turn.wait/deprecatedtimeoutandmax_wait(0–3600 seconds) bound caller collection only. The configured turn limit (default 500) remains the execution budget. Native collection pauses parent inactivity; a parent inactivity timeout/lease loss does not terminate independently owned detached children.No merge, deployment, live session database access, or Jarvis configuration change.
Authorized reviews and fixes
Exactly the two already-running read-only reviews were collected, with no additional reviews or paid-model calls:
chatgpt:gpt-6-astra-medium, runrun_0gR3wk4JpMDJ— completed, changes requested; four substantive findings.claude-bin:opus-max, runrun_A6cqN36FYSFl— completed, changes requested; blocking and important lifecycle/provider findings.Both reviewed
376dadbdc432816b663b5bccea3d149025611337. The follow-up commit isec534ba094821625349dea4dd870be3fe01fa2a2; the reviewers have not re-reviewed or approved that follow-up.Addressed with targeted regressions:
wait_agent.Actual CI failure investigation
The original
testjob failed atTestTelegramSessionMgrResetSessionIfCurrent_CancelsActiveStream:cleanup calls = 0, want 1. This was inspected from the failed job log, not dismissed as unrelated. Race stress reproduced the failure locally: the stream finishes before deliberately deferred runner-owned cleanup. The test now synchronizes with the cleanup callback rather than goroutine scheduling. The same stress command passes after the fix (2,000 repetitions at each of 1/2/8/32 CPUs = 8,000 cases).Validation on the follow-up
Go 1.26.8, temporary HOME/XDG and temporary test databases; module cache preserved:
go test ./...— passed.go test -race ./cmd ./internal/tools ./internal/session ./internal/llm -run 'Test(Agent|PendingAgent|NativeAgent|HostLifecycle|ClaudeBinDelivers|MarkedLifecycle)' -count=1— passed.go test -race ./internal/serve -run '^TestTelegramSessionMgrResetSessionIfCurrent_CancelsActiveStream$' -count=2000 -cpu=1,2,8,32— passed after reproducing failures before the fix.go vet ./...,make build,make complexity,git diff --check— passed.Nested terminal modules and frontend source are unchanged; no separate local nested/frontend suites or live model/browser/Telegram delivery tests were run. Provider checks are serializer tests, not credentialed live requests.
Current CI
Head
ec534ba094821625349dea4dd870be3fe01fa2a2, workflow https://github.com/SamSaffron/term-llm/actions/runs/37422156006, observed 2026-10-06 06:18 UTC:test,changes,passkey-smoke,race,cross-build: passed.frontend: failed at production-shaped Hub browser smoke: five node-order cases infrontend/e2e/hub-node-order.spec.ts(desktop drag/sidebar/node-token order and mobile/iPhone long-press order) time out with expected nodes absent. The failed job logs were fetched and inspected. Causality has not been established and this is not dismissed as unrelated. Reproduction/fix remains outstanding; recovery coordinator execution budget is exhausted.Remaining caveats