Skip to content

fix(#287): clear focus mode polling on app quit#325

Open
Shreya-nipunge wants to merge 1 commit into
SamXop123:mainfrom
Shreya-nipunge:fix-287-focus-mode-timer-cleanup
Open

fix(#287): clear focus mode polling on app quit#325
Shreya-nipunge wants to merge 1 commit into
SamXop123:mainfrom
Shreya-nipunge:fix-287-focus-mode-timer-cleanup

Conversation

@Shreya-nipunge

Copy link
Copy Markdown
Contributor

Description

Adds Focus Mode polling cleanup to the Electron before-quit handler.

Previously, stopFocusModePolling() was only called from window-all-closed, so Focus Mode polling could remain active during shutdown paths such as quitting from the tray or overlay context menu.

Related Issue

Fixes #287

Changes Made

  • Added stopFocusModePolling() to the before-quit cleanup path.
  • Preserved the existing window-all-closed Focus Mode cleanup.
  • Kept the change scoped to main.js.

Testing

  • git diff
  • git diff --check
  • npm.cmd test — passed (14/14 tests)
  • npm.cmd pkg get scripts — confirmed no lint script is available

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

@Shreya-nipunge is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2345abaa-afae-466a-be1e-29b6f9ac7606

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear Focus Mode timer on quit

1 participant