fix(#287): clear focus mode polling on app quit#325
Conversation
|
@Shreya-nipunge is attempting to deploy a commit to the Dot_NotSam's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Adds Focus Mode polling cleanup to the Electron
before-quithandler.Previously,
stopFocusModePolling()was only called fromwindow-all-closed, so Focus Mode polling could remain active during shutdown paths such as quitting from the tray or overlay context menu.Related Issue
Fixes #287
Changes Made
stopFocusModePolling()to thebefore-quitcleanup path.window-all-closedFocus Mode cleanup.main.js.Testing
git diffgit diff --checknpm.cmd test— passed (14/14 tests)npm.cmd pkg get scripts— confirmed no lint script is available